[BGPCEP-425] bgpcep fails to build when using parallel build Created: 29/Mar/16  Updated: 24/Jan/23

Status: Confirmed
Project: bgpcep
Component/s: General
Affects Version/s: Bugzilla Migration
Fix Version/s: None

Type: Improvement Priority: Low
Reporter: Thanh Ha (zxiiro) Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Blocks
is blocked by ODLPARENT-262 SingleFeatureTest needs to be safe to... In Progress

 Description   

bgp-bmp-impl fails to build with the following error when built using MAVEN_OPTS=T1.5C For example:

mvn clean install -T1.5C

It would be nice to be able to run bgpcep builds in parallel as it speeds up the build quite a bit.

[INFO] — maven-install-plugin:2.5.2:install (default-install) @ integration-tests —
[INFO] Installing /home/zxiiro/git/odl/bgpcep/integration-tests/target/integration-tests-0.6.0-SNAPSHOT.jar to /tmp/m2repo/org/opendaylight/bgpcep/integration-tests/0.6.0-SNAPSHOT/integration-tests-0.6.0-SNAPSHOT.jar
[INFO] Installing /home/zxiiro/git/odl/bgpcep/integration-tests/pom.xml to /tmp/m2repo/org/opendaylight/bgpcep/integration-tests/0.6.0-SNAPSHOT/integration-tests-0.6.0-SNAPSHOT.pom
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.23 sec - in org.opendaylight.protocol.bgp.openconfig.impl.comparator.OpenConfigComparatorsTest
Running org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPAppPeerProviderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.784 sec - in org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPAppPeerProviderTest
Running org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPConfigModuleProviderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.174 sec - in org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPConfigModuleProviderTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.205 sec - in org.opendaylight.bgpcep.pcep.topology.provider.Stateful07TopologySessionListenerTest
Running org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPOpenConfigListenerTest
Running org.opendaylight.bgpcep.pcep.topology.provider.SyncOptimizationTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.276 sec <<< FAILURE! - in org.opendaylight.protocol.bmp.impl.app.BmpMonitorImplTest
testMonitoringStation(org.opendaylight.protocol.bmp.impl.app.BmpMonitorImplTest) Time elapsed: 5.262 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.opendaylight.protocol.bmp.impl.app.BmpMonitorImplTest.testMonitoringStation(BmpMonitorImplTest.java:296)

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.078 sec - in org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPOpenConfigListenerTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.986 sec - in org.opendaylight.bgpcep.pcep.topology.provider.SyncOptimizationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.526 sec - in org.opendaylight.bgpcep.bgp.topology.provider.Ipv6ReachabilityTopologyBuilderTest
Running org.opendaylight.protocol.bmp.impl.message.InitiationHandlerTest
Running org.opendaylight.bgpcep.pcep.topology.provider.TopologyProgrammingTest
Running org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPPeerProviderTest
Running org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.359 sec - in org.opendaylight.protocol.bmp.impl.message.InitiationHandlerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.966 sec - in org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPPeerProviderTest
Running org.opendaylight.protocol.bmp.impl.message.PeerDownHandlerTest
Running org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPRibImplProviderTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.525 sec - in org.opendaylight.protocol.bmp.impl.message.PeerDownHandlerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.053 sec - in org.opendaylight.protocol.bgp.openconfig.impl.moduleconfig.BGPRibImplProviderTest
Running org.opendaylight.protocol.bmp.impl.message.PeerUpHandlerTest
Running org.opendaylight.protocol.bgp.openconfig.impl.openconfig.AbstractBGPNeighborProviderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.764 sec - in org.opendaylight.protocol.bgp.openconfig.impl.openconfig.AbstractBGPNeighborProviderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.412 sec - in org.opendaylight.protocol.bmp.impl.message.PeerUpHandlerTest
Running org.opendaylight.protocol.bgp.openconfig.impl.openconfig.AbstractBGPOpenConfigMapperTest
Running org.opendaylight.protocol.bmp.impl.message.RouteMonitoringMessageHandlerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.492 sec - in org.opendaylight.protocol.bgp.openconfig.impl.openconfig.AbstractBGPOpenConfigMapperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.176 sec - in org.opendaylight.protocol.bmp.impl.message.RouteMonitoringMessageHandlerTest
Running org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPAppNeighborProviderImplTest
Running org.opendaylight.protocol.bmp.impl.message.StatisticsReportHandlerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.606 sec - in org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPAppNeighborProviderImplTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.72 sec - in org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.978 sec - in org.opendaylight.protocol.bmp.impl.message.StatisticsReportHandlerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.335 sec - in org.opendaylight.bgpcep.pcep.topology.provider.TopologyProgrammingTest
Running org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPConfigMapperRegistryTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.801 sec - in org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPConfigMapperRegistryTest
Running org.opendaylight.bgpcep.bgp.topology.provider.UriBuilderTest
Running org.opendaylight.protocol.bmp.impl.message.TerminationHandlerTest
Running org.opendaylight.controller.config.yang.pcep.topology.provider.PCEPTopologyProviderModuleTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.892 sec - in org.opendaylight.bgpcep.bgp.topology.provider.UriBuilderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.782 sec - in org.opendaylight.protocol.bmp.impl.message.TerminationHandlerTest
Running org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPConfigModuleMapperProviderTest
Running org.opendaylight.controller.config.yang.bgp.topology.provider.Ipv4ReachabilityTopologyBuilderModuleTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.629 sec - in org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPConfigModuleMapperProviderTest
Running org.opendaylight.protocol.bmp.impl.session.BmpDispatcherImplTest
Running org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPGlobalProviderImplTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.836 sec - in org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPGlobalProviderImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.953 sec - in org.opendaylight.protocol.bmp.impl.session.BmpDispatcherImplTest
Running org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPNeighborProviderImplTest
Running org.opendaylight.protocol.bmp.impl.session.BmpSessionImplTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.651 sec - in org.opendaylight.protocol.bgp.openconfig.impl.openconfig.BGPNeighborProviderImplTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.518 sec - in org.opendaylight.protocol.bmp.impl.session.BmpSessionImplTest
Running org.opendaylight.protocol.bgp.openconfig.impl.util.OpenConfigUtilTest

Results :

Failed tests:
BmpMonitorImplTest.testMonitoringStation:296 null

Tests run: 29, Failures: 1, Errors: 0, Skipped: 0

 Comments   
Comment by Thanh Ha (zxiiro) [ 29/Mar/16 ]

The project that fails seems to change with each run. I think it's just the fact that test are being run in parallel. Would be interesting to know if there's anything we can do to allow the parallel build.

Comment by Kevin Wang [ 29/Apr/16 ]

Right now there should be no problem run "mvn clean install -DskipTests -T1.5C"

It might be possible to run test in parallel as well. However, there are a lot of tests using a fixed port. I will need to take some time to fix all these tests to get parallel test work.

Comment by Viera Zelcamova [ 03/Jan/17 ]

Hi Kevin, are you working on this bug? It is supposed to be done in Boron SR2. Thank you.

Comment by Kevin Wang [ 05/Jan/17 ]

(In reply to Viera Zelcamova from comment #3)
> Hi Kevin, are you working on this bug? It is supposed to be done in Boron
> SR2. Thank you.

Sorry I am not actively working on this one right now.

Comment by Robert Varga [ 05/Aug/17 ]

Nice-to-have, hence an improvement.

Comment by Robert Varga [ 16/Nov/21 ]

While the bgpcep test suite needs to be cleaned up, there is prerequisite work that needs to be done before a parallel build has a chance to work.

Comment by Robert Varga [ 24/Jan/23 ]

Currently-preferred way of parallelizing builds is using 'mvnd', which works reasonably-well for regular JUnit tests. SFT is still prone to port conflicts, but that should be solved in ODLPARENT-262.

Generated at Wed Feb 07 19:13:01 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.