Operating System: All
Platform: All

Requires BGPCEP-618 ?

This should also include the failure due to NoSuchFileException: etc/opendaylight/bgp in bgpcep/features/bmp (the above for in bgpcep/features/bgp/) for:

"odl-bgpcep-bmp"

Hi Michael, I think this is a duplicate of 7558. Issue was solved one day before you open this bug, and there were other patch merged after it without any problems. So no sure why do you still seeing the failure.

Could you confirm if this issue still valid to you, and how to replicate it?

> I think this is a duplicate of BGPCEP-618

not quite - in BGPCEP-618 you believe to have fixed the (or just a?) root cause, where as the goal of this issue is to remove bgpcep features from the BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest in odlparent.

BTW: Are you sure BGPCEP-618 fixed both the "NoSuchFileException: etc/...." in in bgpcep/features/bgp/ as well as the NoSuchFileException in bgpcep/features/bmp - see above?

> So no sure why do you still seeing the failure.

I'm not seeing these anymore - because we've blacklisted 4 of your affected features.

> Could you confirm if this issue still valid to you,

Yes, this issue is still valid - it's goal is to remove bgpcep features from the BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest in odlparent.

> and how to replicate it?

You have to:

1. git clone odlparent

2. tentatively locally remove your 4 features from the BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest

3. mvn install in org.opendaylight.odlparent.features-test

4. mvn clean package both bgpcep/features/bgp/ as well as in bgpcep/features/bmp

5. fix any remaining broken features in bgpcep (if any; great if not)

6. raise a Gerrit change against odlrelease with the clean up & removal of the 4 bgpcep related BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest in odlparent, if you're confident it won't break autorelease again for everyone.

> 6. raise a Gerrit change against odlrelease

s/odlrelease/odlparent => "raise a Gerrit change against odlparent"

(In reply to Michael Vorburger from comment #4)
> > I think this is a duplicate of BGPCEP-618
>
> not quite - in BGPCEP-618 you believe to have fixed the (or just a?) root
> cause, where as the goal of this issue is to remove bgpcep features from the
> BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest in odlparent.
>
> BTW: Are you sure BGPCEP-618 fixed both the "NoSuchFileException: etc/...." in
> in bgpcep/features/bgp/ as well as the NoSuchFileException in
> bgpcep/features/bmp - see above?
>
> > So no sure why do you still seeing the failure.
>
> I'm not seeing these anymore - because we've blacklisted 4 of your affected
> features.
>
> > Could you confirm if this issue still valid to you,
>
> Yes, this issue is still valid - it's goal is to remove bgpcep features from
> the BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest in odlparent.
>
> > and how to replicate it?
>
> You have to:
>
> 1. git clone odlparent
>
> 2. tentatively locally remove your 4 features from the
> BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest
>
> 3. mvn install in org.opendaylight.odlparent.features-test
>
> 4. mvn clean package both bgpcep/features/bgp/ as well as in
> bgpcep/features/bmp
>
> 5. fix any remaining broken features in bgpcep (if any; great if not)
>
> 6. raise a Gerrit change against odlrelease with the clean up & removal of
> the 4 bgpcep related BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest in
> odlparent, if you're confident it won't break autorelease again for everyone.

Hi Michael, thanks for the clarification.

this bug is opened against BGPCEP features presence under BLACKLISTED_BROKEN_FEATURES and not against any issue/error, since they are no longer present at the moment of the creation of this bug. Therefore the objective is to remove the from the list since they are not longer required.

https://git.opendaylight.org/gerrit/#/c/50770/

(In reply to Claudio D. Gasparini from comment #7)
> this bug is opened against BGPCEP features presence under
> BLACKLISTED_BROKEN_FEATURES and not against any issue/error, since they are
> no longer present at the moment of the creation of this bug. Therefore the
> objective is to remove the from the list since they are not longer required.
>
> https://git.opendaylight.org/gerrit/#/c/50770/

I'm pretty sure Michael filed this bug to track the fix in bgpcep, not the blacklist removal in odlparent, but never mind.

(In reply to Stephen Kitt from comment #8)
> (In reply to Claudio D. Gasparini from comment #7)
> > this bug is opened against BGPCEP features presence under
> > BLACKLISTED_BROKEN_FEATURES and not against any issue/error, since they are
> > no longer present at the moment of the creation of this bug. Therefore the
> > objective is to remove the from the list since they are not longer required.
> >
> > https://git.opendaylight.org/gerrit/#/c/50770/
>
> I'm pretty sure Michael filed this bug to track the fix in bgpcep, not the
> blacklist removal in odlparent, but never mind.

If so, the bug was opened without doing a previous check if the error were still valid...

Michael comment
"not quite - in BGPCEP-618 you believe to have fixed the (or just a?) root cause, where as the goal of this issue is to remove bgpcep features from the BLACKLISTED_BROKEN_FEATURES in SingleFeatureTest in odlparent."

Regards,

> I'm pretty sure Michael filed this bug to track the fix in bgpcep, not the blacklist removal in odlparent, but never mind.

Stephen sorry to contradict, I was hoping that all remaining affected projects both fix there features as well as propose patches to odlparent to remove their blacklisted features once they're OK, so that myself or you don't have to do that part...

See also similar update just made on LISPMAP-147.