[#BGPCEP-670] PCEP module doesn't honor configuration from blueprint

[BGPCEP-670] PCEP module doesn't honor configuration from blueprint Created: 11/May/17 Updated: 03/Mar/19 Resolved: 18/Aug/17
Status:	Resolved
Project:	bgpcep
Component/s:	PCEP
Affects Version/s:	Bugzilla Migration
Fix Version/s:	Bugzilla Migration

Type:

Bug

Reporter:

Kevin Wang

Assignee:

Unassigned

Resolution:

Cannot Reproduce

Votes:

Labels:

None

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Environment:

Operating System: All
Platform: All

External issue ID:

8425

Description

The intention is to change keepalive timer through RESTCONF in Boron

http://controller-ip:restconf-port/restconf/config/pcep-app-config:pcep-session-config

{
"pcep-session-config" :

{ "keep-alive-timer-value" : 20, "dead-timer-value": 80 }

}

Even though the PUT restcall succeeded with a 201 ok, and the XRv router match with the same timer values; the Controller default timers still unchanged as the controller logs are displayed:

– Controller default timers:

{channel=[id: 0x689bf233, L:/10.18.133.36:4189 - R:/10.18.133.207:50476], localOpen=Open [_deadTimer=120, _keepalive=30, _sessionId=23, _tlvs=Tlvs [augmentation=[Tlvs1 [_srPceCapability=SrPceCapability [_msd=0, augmentation=[]]], Tlvs1 XRv new timers: [_stateful=Stateful [_lspUpdateCapability=true, augmentation=[Stateful1 [_deltaLspSyncCapability=true, _includeDbVersion=true, _triggeredInitialSync=true, _triggeredResync=true], Stateful1 [_initiation=true]]]]]], augmentation=[]], remoteOpen=Open [_deadTimer=100, _keepalive=25, _sessionId=5, _tlvs=Tlvs [augmentation=[Tlvs3 [], Tlvs1 [], Tlvs1 [_stateful=Stateful [_lspUpdateCapability=true, augmentation=[Stateful1 [], Stateful1 [_initiation=true]]]]]], _version=ProtocolVersion [_value=1], _ignore=false, _processingRule=false, augmentation=[]]}

terminated by peer with reason PCEPCloseTermination

{reason=EXP_DEADTIMER}

The Controller's keep alive timer and dead timer remains the same after RESTCONF PUT

Comments

Comment by Claudio David Gasparini [ 15/May/17 ]

Again please attach logs, version, etc..

Comment by Ajay L [ 17/Aug/17 ]

As the log snippet in bug description show, the bug was seen in Boron-SR2. When I try with latest Boron SR4 now, issue is not present i.e. pcep-session-config parameters are changed, the session flaps and new values are used

Looks like PCEP Blueprint related changes that went between SR2 and SR4 (BUG-6973, et al) have fixed it. So closing this issue

Boron-SR2 log
---------------
2017-08-17 12:44:35,092 | INFO | erRestartService | printContainerRestartServiceImpl | 176 - org.opendaylight.controller.blueprint - 0.5.2.Boron-SR2 | Restarting blueprint containers for bundle org.opendaylight.bgpcep.pcep-impl_0.6.2.Boron-SR2 [277] and its dependent bundles []
2017-08-17 12:44:35,094 | INFO | erRestartService | BlueprintExtender | 15 - org.apache.aries.blueprint.core - 1.6.1 | Destroying BlueprintContainer for bundle org.opendaylight.bgpcep.pcep-impl/0.6.2.Boron-SR2
2017-08-17 12:44:35,101 | INFO | erRestartService | printContainerRestartServiceImpl | 176 - org.opendaylight.controller.blueprint - 0.5.2.Boron-SR2 | Restarting blueprint container for bundle org.opendaylight.bgpcep.pcep-impl_0.6.2.Boron-SR2 [277] with paths [bundleentry://277.fwk2097514481/org/opendaylight/blueprint/pcep-impl.xml]
2017-08-17 12:44:35,127 | WARN | erRestartService | BasePCEPSessionProposalFactory | 277 - org.opendaylight.bgpcep.pcep-impl - 0.6.2.Boron-SR2 | dead-timer-value should be 4 times greater than keep-alive-timer-value
2017-08-17 12:44:35,135 | INFO | tAdminThread #19 | BlueprintBundleTracker | 176 - org.opendaylight.controller.blueprint - 0.5.2.Boron-SR2 | Blueprint container for bundle org.opendaylight.bgpcep.pcep-impl_0.6.2.Boron-SR2 [277] was successfully created

Boron-SR4 log
---------------

2017-08-17 11:12:20,413 | INFO | erRestartService | printContainerRestartServiceImpl | 175 - org.opendaylight.controller.blueprint - 0.5.4.Boron-SR4 | Restarting blueprint containers for bundle org.opendaylight.bgpcep.pcep-impl_0.6.4.Boron-SR4 [278] and its dependent bundles [org.opendaylight.bgpcep.pcep-topology-provider_0.6.4.Boron-SR4 [292]]
2017-08-17 11:12:20,414 | INFO | erRestartService | BlueprintExtender | 15 - org.apache.aries.blueprint.core - 1.6.1 | Destroying BlueprintContainer for bundle org.opendaylight.bgpcep.pcep-topology-provider/0.6.4.Boron-SR4
2017-08-17 11:12:20,422 | INFO | erRestartService | PCEPTopologyProviderBean | 292 - org.opendaylight.bgpcep.pcep-topology-provider - 0.6.4.Boron-SR4 | Close PCEP Topology Provider Singleton Service programming-global-instruction-queue-service-group

<snip>

2017-08-17 11:15:46,309 | INFO | erRestartService | PCEPTopologyProviderBean | 292 - org.opendaylight.bgpcep.pcep-topology-provider - 0.6.4.Boron-SR4 | PCEP Topology Provider Singleton Service programming-global-instruction-queue-service-group instantiated
2017-08-17 11:15:56,488 | INFO | ntLoopGroup-12-1 | PCEPSessionNegotiator | 278 - org.opendaylight.bgpcep.pcep-impl - 0.6.4.Boron-SR4 | Replacing bootstrap negotiator for channel [id: 0x904a651c, L:/10.18.130.37:4189 - R:/10.18.132.92:51021]
2017-08-17 11:15:56,490 | INFO | ntLoopGroup-12-1 | AbstractPCEPSessionNegotiator | 278 - org.opendaylight.bgpcep.pcep-impl - 0.6.4.Boron-SR4 | PCEP session with [id: 0x904a651c, L:/10.18.130.37:4189 - R:/10.18.132.92:51021] started, sent proposal Open [_deadTimer=90, _keepalive=15, _sessionId=0, _tlvs=Tlvs [augmentation=[Tlvs1 [_stateful=Stateful [_lspUpdateCapability=true, augmentation=[Stateful1 [_deltaLspSyncCapability=true, _includeDbVersion=true, _triggeredInitialSync=true, _triggeredResync=true], Stateful1 [_initiation=true]]]], Tlvs1 [_srPceCapability=SrPceCapability [_msd=0, augmentation=[]]]]], augmentation=[]]
2017-08-17 11:15:56,495 | INFO | ntLoopGroup-12-1 | AbstractPCEPSessionNegotiator | 278 - org.opendaylight.bgpcep.pcep-impl - 0.6.4.Boron-SR4 | PCEP peer [id: 0x904a651c, L:/10.18.130.37:4189 - R:/10.18.132.92:51021] completed negotiation
2017-08-17 11:15:56,496 | INFO | ntLoopGroup-12-1 | PCEPSessionImpl | 278 - org.opendaylight.bgpcep.pcep-impl - 0.6.4.Boron-SR4 | Session /10.18.130.37:4189[0] <-> /10.18.132.92:51021[4] started
2017-08-17 11:15:56,500 | INFO | ntLoopGroup-12-1 | AbstractTopologySessionListener | 292 - org.opendaylight.bgpcep.pcep-topology-provider - 0.6.4.Boron-SR4 | Session with /10.18.132.92 attached to topology node KeyedInstanceIdentifier

{targetType=interface org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node, path=[org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NetworkTopology, org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.Topology[key=TopologyKey [_topologyId=Uri [_value=pcep-topology]]], org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node[key=NodeKey [_nodeId=Uri [_value=pcc://10.18.132.92]]]]}

Generated at Wed Feb 07 19:13:47 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.

[BGPCEP-670] PCEP module doesn't honor configuration from blueprint Created: 11/May/17 Updated: 03/Mar/19 Resolved: 18/Aug/17