Operating System: All
Platform: All

Attachment karaf.log has been added with description: Karaf Log

Master: https://git.opendaylight.org/gerrit/#/c/63464/

https://git.opendaylight.org/gerrit/#/q/topic:Bug-9186

Hi Ajay, please extend the issue, scenario and what you are trying to achieve and its failing.

After check the patch, from my point of view what you are doing is a missconfiguration and therefore you are hitting the NPE.

Regards,

Claudio

When Configuring ADD PATH capabilty.

• global/rib it should be configured per AFI/SAFI if its supported and what strategy will be used. send-max field is mandatory
• peer here send-max is not mandatory, from doc:

Note
The path selection strategy is not configurable on per peer basis. The send-max presence indicates a willingness to send ADD-PATH NLRIs to the neighbor.

Regards,

Claudio

(In reply to Claudio D. Gasparini from comment #3)
> Hi Ajay, please extend the issue, scenario and what you are trying to
> achieve and its failing.
>
> After check the patch, from my point of view what you are doing is a
> missconfiguration and therefore you are hitting the NPE.
>
> Regards,
>
> Claudio

The issue was found while testing add-path capability modes (ref. https://tools.ietf.org/html/rfc7911#page-4). In version of OpenConfig model currently used by ODL BGP code, there is no separate provision to specify that send capability should not be advertised. Only value associated with send is send-max. If it is not specified, it was causing NPE. This patch adds check to prevent NPE. So now for send capability not to be advertised, send-max can be skipped

BGP OpenConfig model has been updated recently to add a boolean flag for specifying if send capability should be advertised (ref. https://github.com/openconfig/public/commit/e020ce4b7e94482a9bbcf8dfb73f3d01dbdda5e6#diff-0d759af0e8ee335a03ba94fd5055d69cL312) which is the correct way of doing this and once we update to this version above will not be required

(In reply to Claudio D. Gasparini from comment #4)
> When Configuring ADD PATH capabilty.
> - global/rib it should be configured per AFI/SAFI if its supported and what
> strategy will be used. send-max field is mandatory

where is send-max mentioned as mandatory and how do we enforce it? I don't see it as mandatory in the yang

> - peer here send-max is not mandatory, from doc:
>
> Note
> The path selection strategy is not configurable on per peer basis. The
> send-max presence indicates a willingness to send ADD-PATH NLRIs to the
> neighbor.
>

I don't understand this doc note. Generally per neighbor config should override the global config

>
>
> Regards,
>
>
> Claudio

(In reply to Ajay Lele from comment #6)
> (In reply to Claudio D. Gasparini from comment #4)
> > When Configuring ADD PATH capabilty.
> > - global/rib it should be configured per AFI/SAFI if its supported and what
> > strategy will be used. send-max field is mandatory
>
> where is send-max mentioned as mandatory and how do we enforce it? I don't
> see it as mandatory in the yang
>
> > - peer here send-max is not mandatory, from doc:
> >
> > Note
> > The path selection strategy is not configurable on per peer basis. The
> > send-max presence indicates a willingness to send ADD-PATH NLRIs to the
> > neighbor.
> >
>
> I don't understand this doc note. Generally per neighbor config should
> override the global config
>
> >
> >
> > Regards,
> >
> >
> > Claudio

Hi Ajay, global configuration is used to defined the path selection strategy to be used when supporting add-path(only configurable per RIB).
Then neighbor config is used to define the additional capability per neighbor(receive flag and send flag). As you mentioned send flag is not present therefore send-max presence is used as flag.

All this is mentioned in documentation, if you thing that it can be improved, feel free to provide some improvement and we can go through it.

[0] http://docs.opendaylight.org/en/stable-nitrogen/user-guide/bgp-user-guide.html#additional-path

Could you close the bug as wont be fixed.

Thanks

Hi Claudio

Ok I see what you are saying. So to achieve what is intended, config required is:
1. config add-path (both receive and send-max params) at global level
2. exclude send-max param under neighbor config

I tried it out and confirm that it works. Fine to close this issue

Regards
Ajay