[BGPCEP-732] BGP Peer name forced to be Ipv4 Created: 07/Dec/17 Updated: 18/Apr/18 Resolved: 27/Mar/18 |
|
| Status: | Verified |
| Project: | bgpcep |
| Component/s: | None |
| Affects Version/s: | Oxygen |
| Fix Version/s: | None |
| Type: | Bug | Priority: | High |
| Reporter: | Ján Srniček | Assignee: | Claudio David Gasparini |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
in org.opendaylight.protocol.bgp.rib.impl.BGPPeer constructor peer name(String) is used as following super(rib.getInstanceIdentifier(), null, new IpAddress(new Ipv4Address(name)), afiSafisAdvertized,afiSafisGracefulAdvertized);
When used in in org.opendaylight.protocol.bgp.rib.impl.config.BGPPeer this.bgpPeer = new BGPPeer(Ipv4Util.toStringIP(this.neighborAddress), rib,
Where this.neighorAddress is defined as following private final IpAddress neighborAddress;
which is equal to how it is represented in model.
Therefore its not possible right now to create V6 peer, because if v6 address is provided as neghbors address, it will fail at v4 regex that will be used by new IpAddress(new Ipv4Address(name)
This problem was introduced by patch https://git.opendaylight.org/gerrit/#/c/49933/12/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java Affects nitrogen and carbon.SR2 also
|
| Comments |
| Comment by Claudio David Gasparini [ 07/Dec/17 ] |
|
When passing the bgp identifier, is defined as Ipv4 by definition, which is wrong since its an IpAddress, allowing to be Ipv4/Ipv6. |
| Comment by Claudio David Gasparini [ 07/Dec/17 ] |
| Comment by Ján Srniček [ 12/Dec/17 ] |
|
Should be also cherry picked for nitrogen.SR1 and carbon.SR2 |
| Comment by Claudio David Gasparini [ 12/Dec/17 ] |
|
If I recall well, we agreed that you will test it and confirm the fix. I don't see anywhere that confirmation. Also you mention the cherry-pick but I don't see that you have done it. Once you do it, attach me as reviewer, and I'll review and merge them. But first confirm the fix is correct.
Regards |
| Comment by Ján Srniček [ 12/Dec/17 ] |
|
I cannot confirm it works for my usecase unless its cherry picked to either carbon or nitrogen. And i dont have rights do so in ODL gerrit |
| Comment by Ján Srniček [ 12/Dec/17 ] |
|
Sorry ,my mistake ,i can see cherry pick |