[BGPCEP-860] Session establishment does not work with AS number >= 2^31 Created: 28/Jan/19  Updated: 29/Jan/19  Resolved: 29/Jan/19

Status: Resolved
Project: bgpcep
Component/s: BGP
Affects Version/s: Oxygen SR4
Fix Version/s: Neon, Fluorine SR2

Type: Bug Priority: Medium
Reporter: Robert Varga Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

In case AS number is configured to be greater than Integer.MAX_VALUE, the session will not be established:

2019-01-28T09:55:45,915 | WARN  | epollEventLoopGroup-7-2 | AbstractBGPSessionNegotiator     | 210 - org.opendaylight.bgpcep.bgp-rib-impl - 0.9.4 | Unexpected negotiation failure

java.lang.IllegalArgumentException: Invalid range: -2147483648, expected: [[0..65535]].

                at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev171207.OpenBuilder.checkMyAsNumberRange(OpenBuilder.java:148) [204:org.opendaylight.bgpcep.bgp-parser-api:0.9.4]

                at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev171207.OpenBuilder.setMyAsNumber(OpenBuilder.java:153) [204:org.opendaylight.bgpcep.bgp-parser-api:0.9.4]

                at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator.startNegotiation(AbstractBGPSessionNegotiator.java:116) [210:org.opendaylight.bgpcep.bgp-rib-impl:0.9.4]

                at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator.channelActive(AbstractBGPSessionNegotiator.java:279) [210:org.opendaylight.bgpcep.bgp-rib-impl:0.9.4]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:213) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:199) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.fireChannelActive(AbstractChannelHandlerContext.java:192) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.ChannelInboundHandlerAdapter.channelActive(ChannelInboundHandlerAdapter.java:64) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:213) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:199) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.fireChannelActive(AbstractChannelHandlerContext.java:192) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.ChannelInboundHandlerAdapter.channelActive(ChannelInboundHandlerAdapter.java:64) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:213) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:199) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.fireChannelActive(AbstractChannelHandlerContext.java:192) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.DefaultChannelPipeline$HeadContext.channelActive(DefaultChannelPipeline.java:1422) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:213) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:199) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.DefaultChannelPipeline.fireChannelActive(DefaultChannelPipeline.java:941) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:518) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:423) [106:io.netty.transport:4.1.30.Final]

                at io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:482) [106:io.netty.transport:4.1.30.Final]

                at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) [103:io.netty.common:4.1.30.Final]

                at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) [103:io.netty.common:4.1.30.Final]

                at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:326) [107:io.netty.transport-native-epoll:4.1.30.Final]

                at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:897) [103:io.netty.common:4.1.30.Final]

                at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [103:io.netty.common:4.1.30.Final]

                at java.lang.Thread.run(Thread.java:748) [?:?]
Generated at Wed Feb 07 19:14:19 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.