[BGPCEP-861] Audit and fix use of read-only transactions in openconfig-rp-statement Created: 29/Jan/19 Updated: 07/Jan/21 Resolved: 07/Jan/21 |
|
| Status: | Resolved |
| Project: | bgpcep |
| Component/s: | BGP |
| Affects Version/s: | None |
| Fix Version/s: | Silicon |
| Type: | Bug | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Claudio David Gasparini |
| Resolution: | Done | Votes: | 0 |
| Labels: | pt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Cursory look during migration to MD-SAL APIs reveals this component is not properly closing read-only transactions. Audit all callers and make sure transactions are used in a proper try-with-resources block. While we are in the area, it seems the results of the call could use Optional.map() handling rather than the explicit isPresent()/get() combo. |
| Comments |
| Comment by Robert Varga [ 16/Oct/20 ] |
|
tnevrekarstill working on this? |
| Comment by Tejas Nevrekar [ 17/Oct/20 ] |
|
No @robert. I started looking at this last year and saw you had already fixed most of these issues. Maybe you can resolve it or let me know if any are missing |
| Comment by Robert Varga [ 17/Oct/20 ] |
|
Alright, let's see if I can find someone to deal with this. |