[BGPCEP-880] Fix usage of duplicate child element in choice case statement in bgpcep yang files Created: 13/Sep/19 Updated: 02/Dec/19 Resolved: 02/Dec/19 |
|
| Status: | Resolved |
| Project: | bgpcep |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | Neon SR3, Magnesium, Sodium SR2 |
| Type: | Bug | Priority: | Medium |
| Reporter: | Ajay Lele | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
Yang spec [0] states that child elements appearing in different case statements of a choice must be unique. The identifiers of all these child nodes MUST be unique within all cases in a choice This is violated at a few places in bgpcep yang files resulting in issues such as one reported in [1]. Opening this ticket to fix the usage in yang files [0] https://tools.ietf.org/html/rfc7950#section-7.9.2 [1] https://jira.opendaylight.org/browse/YANGTOOLS-1026 |
| Comments |
| Comment by Robert Varga [ 21/Oct/19 ] |
|
ajayslele we have fixed-up parser in all streams now, the Neon being on https://git.opendaylight.org/gerrit/q/topic:mri-neon-sr3 . This flushes out all the BGPCEP offenders – I have created patches (see Reviews here), but the second one seems to be failing a UT. Can you take a look? |
| Comment by Robert Varga [ 22/Oct/19 ] |
|
Never mind, I found the fat-fingers mistake. |
| Comment by Ajay Lele [ 22/Oct/19 ] |
|
ok, thx |