[BGPCEP-903] Misnamed features graph and algo in magnesium documentation Created: 09/Apr/20  Updated: 24/Jul/20

Status: In Review
Project: bgpcep
Component/s: None
Affects Version/s: Magnesium
Fix Version/s: None

Type: Bug Priority: Low
Reporter: Jean-Marc MONTENOT Assignee: Luis Gomez
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

In magnesium documentation, in Running Graph, Running Path Computation and Path Computation Server, feature names are incorrect

in the documentation :

In the Karaf console, type command:

feature:install features-restconf features-graph
feature:install features-restconf features-algo

these features named above doesn't exist. However I found in the karaf features list the following features for graph and algo
 

odl-bgpcep-graph-api                                            │ 0.13.0           │ x        │ Started     │ odl-bgpcep-graph-api                                            │ OpenDaylight :: GRAPH :: API
odl-bgpcep-graph                                                │ 0.13.0           │ x        │ Started     │ odl-bgpcep-graph                                                │ OpenDaylight :: GRAPH
odl-bgpcep-algo                                                 │ 0.13.0           │ x        │ Started     │ odl-bgpcep-algo                                                 │ OpenDaylight :: Path Computation Algorithms
odl-bgpcep-algo-api                                             │ 0.13.0           │ x        │ Started     │ odl-bgpcep-algo-api                                             │ OpenDaylight :: Path Computation Algorithms :: API

to install these features, I used

feature:install odl-bgpcep-graph odl-bgpcep-graph-api
feature:install odl-bgpcep-algo odl-bgpcep-algo-api

 



 Comments   
Comment by Olivier Dugeon [ 09/Jul/20 ]

This is not an error in the documentation, but due to an error in the packaging of ODL.

These features are new and present in the BPCEP project but not embeded in the ODL distribution by default.

Packagers need to add them

 

Comment by Luis Gomez [ 10/Jul/20 ]

Yeah, new feature repos have to be added to distribution, this should fix:

https://git.opendaylight.org/gerrit/c/integration/distribution/+/91044

Comment by Luis Gomez [ 14/Jul/20 ]

BTW the ticket itself seems right as well, normally we do not install features using the repo names like features-*, but individual features like odl-*.

Comment by Olivier Dugeon [ 24/Jul/20 ]

Luis, as mention during the BGPCEP meeting, graph & algo features have been introduced with in mind to be generic as much as possible in order to be reuseable by other project. So, I created feature-graph and feature-algo similarly that feature-pcep and feature-bgp to ease installation of graph and/or algo.

Of course, there are dependencies. If you install feature-pcep, the new pce-server bundle depends from algo which depends from graph. Thus, odl-graph and odl-algo are installed. Same with feature-bgp which has a dependency with odl-graph for the new LinkStateGraphBuilder.

So, I think that feature-graph and feature-algo have their place in the ODL release for peoples who would try them outside BGPCEP project (e.g. for Openflow)

Generated at Wed Feb 07 19:14:27 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.