[BGPCEP-906] Propagate only negotiated afi/safi routes to adj-rib-out Created: 29/May/20  Updated: 07/Dec/20  Resolved: 07/Dec/20

Status: Resolved
Project: bgpcep
Component/s: BGP
Affects Version/s: None
Fix Version/s: Magnesium SR3, Silicon, Aluminium SR1

Type: Bug Priority: Low
Reporter: Vikram Singh Kalakoti Assignee: Vikram Singh Kalakoti
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

When BGP session comes, empty entries for negotiated afi/safi are
created in peer's adj-rib-out. If routes belonging to afi/safi
that were not negotiated for the peer are present in loc-rib,
those entries are being propagated to the peer, resulting in
ModifiedNodeDoesNotExistException. Patch prevents this by allowing
routes for only the negotiated afi/safi to be propagated from
loc-rib to peer's adj-rib-out.

If routes are written to non-existent afi/safi table in adj-rib-out,
it results in transaction chain failure which leads to a scenario
where multiple threads block to get a lock on BGPPeer but the
thread handling transaction failure is waiting for the submitted
futures to exit. Patch fixes this scenario by preventing wait on
the submtited futures when handling transaction failures.



 Comments   
Comment by Tejas Nevrekar [ 23/Jul/20 ]

rovarga could you please review this patch?

Generated at Wed Feb 07 19:14:27 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.