[BGPCEP-962] Remove blueprint from pcep-impl Created: 28/Jun/21  Updated: 04/Jul/23  Resolved: 15/Jan/23

Status: Resolved
Project: bgpcep
Component/s: PCEP
Affects Version/s: None
Fix Version/s: 0.19.0

Type: Task Priority: High
Reporter: Robert Varga Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks BGPCEP-960 Remove blueprint from pcep-topology-p... Resolved
is blocked by BGPCEP-1017 Correct pcep timer types Resolved
Relates
relates to BGPCEP-990 Update pcep-topology-type-config plac... Resolved
relates to BGPCEP-952 Remove blueprint from PCEP extensions Resolved
Epic Link: OSGi deps

 Description   

This is a rather simple blueprint, except it is using odl:clustered-app-config. Convert it to OSGi DS.



 Comments   
Comment by Robert Varga [ 21/Nov/21 ]

Examining what is being configured here, it seems we need to do some amount of switcheroo with pcep-topology-provider, where configuration of PCEP dispatcher is concerned. While we should be defining the layout of pcep-dispatcher-config in pcep-impl, its instantiation really belongs with the listen adress/port configuration – and that is held in pcep-topology-provider and is being placed in the correct place in BGPCEP-990.

A similar thing holds for pcep-session-config, which is governing instantiation of DefaultPCEPSessionNegotiatorFactory. Furthermore these bits should also be configurable for each individual peer.

Once we move these out, pcep-impl's job is really just to expose factories for instantiating dispatchers and proposals to pcep-topology-provider in a manner very similar to how bgp-parser-impl exposes things to bgp-rib-impl.

Generated at Wed Feb 07 19:14:36 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.