|
Examining what is being configured here, it seems we need to do some amount of switcheroo with pcep-topology-provider, where configuration of PCEP dispatcher is concerned. While we should be defining the layout of pcep-dispatcher-config in pcep-impl, its instantiation really belongs with the listen adress/port configuration – and that is held in pcep-topology-provider and is being placed in the correct place in BGPCEP-990.
A similar thing holds for pcep-session-config, which is governing instantiation of DefaultPCEPSessionNegotiatorFactory. Furthermore these bits should also be configurable for each individual peer.
Once we move these out, pcep-impl's job is really just to expose factories for instantiating dispatchers and proposals to pcep-topology-provider in a manner very similar to how bgp-parser-impl exposes things to bgp-rib-impl.
|