[BGPCEP-990] Update pcep-topology-type-config placement Created: 20/Nov/21  Updated: 30/Jul/22  Resolved: 30/Jul/22

Status: Resolved
Project: bgpcep
Component/s: PCEP
Affects Version/s: None
Fix Version/s: 0.18.0

Type: Task Priority: High
Reporter: Robert Varga Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to BGPCEP-962 Remove blueprint from pcep-impl Resolved

 Description   

We are currently doing this in network-pcep-topology-config.yang:

    augment "/nt:network-topology/nt:topology" {
        when "nt:topology-types/pn:topology-pcep";
        ext:augment-identifier pcep-topology-type-config;
        description "Augment Pcep topology with session config";

        uses pdc:pcep-config;
    }

This adds the configuration as an optional thing, where as we really want to make it required – which means it should be part of network-topology-pcep.yang's 'topology-pcep'.

Since topology-pcep is a presence container, it forms a mandatory leaf validation root, and therefore we can express exactly what we mean: things like listen-address etc. are mandatory and it is invalid to try to have a pcep-topology without those knobs.

This will simplify a lot of logic, as we can rely on datastore to enforce this invariant.


Generated at Wed Feb 07 19:14:42 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.