[BIER-3] Migrate IETF Yang files to Mdsal project Created: 09/Jan/17  Updated: 19/Oct/17

Status: Confirmed
Project: bier
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Vratko Polak Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7495

 Description   

This is almost exact copy of HONEYVBD-14 but this applies to BIER and not honeycomb/vbd.
Possibly, both bugs have to be fixed before BIER and VBD could coexist in one ODL container.

Copied text:

Standard Yang files used in ODL should be stored in one place in order to keep revisions under control. Currently the place is in Mdsal project (model/ subdirectories).

When multiple revisions of the same module are present in ODL container, care should be taken. Additional filenames should contain revision (e.g. ietf-inet-types@2013-07-15.yang) and each import statement should use revision-date to avoid unexpected errors when parsing.

An example of such error is shown in comments on patch set 2 of https://git.opendaylight.org/gerrit/49828

 Comments   
Comment by Quan Xiong [ 12/Jan/17 ]

We have added revisions to import.

Comment by Vratko Polak [ 12/Jan/17 ]

> We have added revisions to import.

That would be https://git.opendaylight.org/gerrit/50273

Well, description of this Bug asks for moving all the ietf yang the files to mdsal.models, so this is not fixed from my point of view as Reporter.
But 50273 is a step in the right direction.

Comment by Quan Xiong [ 13/Jan/17 ]

Thank you for your comment. We fixed the files in BIER project for first step.
Cause the IETF is the standard file, I have no idear if we have the authority to add that to Mdsal project. What is the general work way?
By the way, the error is still in integration/distribution project as shown in https://git.opendaylight.org/gerrit/#/c/49828/.
This is because the honeycom/VBD still not resolve the bug. I sent emails but no return. What should we do for that? Thank you.

Comment by Vratko Polak [ 13/Jan/17 ]

There is a problem specific to ietf-routing, tracked as a PERSISTENC-1.

This Bug still applies, as other IETF files may lead to similar problems later,
and Mdsal project (as the host for standard Yang files) would be able to solve them authoritatively for all ODL projects.

> if we have the authority to add that to Mdsal project

Anyone can contribute. I think [0] would be fine (if it did not trigger MDSAL-207).

From my point of view, other ODL projects do not have the authority to add standard Yang modules to ODL without consulting Mdsal project first.

[0] https://git.opendaylight.org/gerrit/#/c/50377/1

Comment by Quan Xiong [ 18/Jan/17 ]

I noticed that [0] is not reviewed. And the failure reason is the MDSAL-207?
This is the best solution.

But at the present stage, [1] is still not successful, as the HONEYVBD-14 is not resolved and [0] is not reviewed.

And we need to add BIER project to integration/distribution in Carbon release.
We will modify the files' name to different one to distinguish with IETF standard files first.

And if the Mdsal model contains that standard files,we will fix again.

Thank you!

[0] https://git.opendaylight.org/gerrit/#/c/50377/1
[1] https://git.opendaylight.org/gerrit/49828

Generated at Wed Feb 07 19:14:52 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.