[CENTINEL-34] CENTINEL Carbon Autorelease Build Failure Created: 01/Dec/16  Updated: 03/May/18  Resolved: 02/Dec/16

Status: Resolved
Project: centinel
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: A H Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7285

 Description   

There are Carbon Autorelease Build Failures in centinel-alertcallback:

https://jenkins.opendaylight.org/releng/view/autorelease/job/autorelease-release-carbon/77/

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project centinel-alertcallback: Compilation failure: Compilation failure:
[ERROR] /w/workspace/autorelease-release-carbon/centinel/plugins/centinel-alertcallback/src/main/java/org/opendaylight/centinel/alertcallback/CentinelAlertCallbackModule.java:[21,8] cannot access com.google.inject.AbstractModule
[ERROR] class file for com.google.inject.AbstractModule not found
[ERROR] /w/workspace/autorelease-release-carbon/centinel/plugins/centinel-alertcallback/src/main/java/org/opendaylight/centinel/alertcallback/CentinelAlertCallbackPlugin.java:[25,53] cannot find symbol
[ERROR] symbol: constructor CentinelAlertCallbackModule()
[ERROR] location: class org.opendaylight.centinel.alertcallback.CentinelAlertCallbackModule
[ERROR] /w/workspace/autorelease-release-carbon/centinel/plugins/centinel-alertcallback/src/main/java/org/opendaylight/centinel/alertcallback/CentinelAlertCallbackModule.java:[22,5] method does not override or implement a method from a supertype
[ERROR] /w/workspace/autorelease-release-carbon/centinel/plugins/centinel-alertcallback/src/main/java/org/opendaylight/centinel/alertcallback/CentinelAlertCallbackModule.java:[24,9] cannot find symbol
[ERROR] symbol: method addAlarmCallback(java.lang.Class<org.opendaylight.centinel.alertcallback.CentinelAlertCallback>)
[ERROR] location: class org.opendaylight.centinel.alertcallback.CentinelAlertCallbackModule
[ERROR] /w/workspace/autorelease-release-carbon/centinel/plugins/centinel-alertcallback/src/main/java/org/opendaylight/centinel/alertcallback/CentinelAlertCallbackModule.java:[27,5] method does not override or implement a method from a supertype

 Comments   
Comment by Alexis de Talhouët [ 01/Dec/16 ]

The culprit is https://git.opendaylight.org/gerrit/#/c/48288/

Reverting it locally solve the issue.

Comment by Alexis de Talhouët [ 01/Dec/16 ]

Proposed fix: https://git.opendaylight.org/gerrit/#/c/48906/

Comment by Michael Vorburger [ 02/Dec/16 ]

> The culprit is https://git.opendaylight.org/gerrit/#/c/48288/

I meanwhile consider the <scope>test I had introduced there a mistake in hindsight (I now realize that it was wrong to "force" a generic not-guaranteed-to-always-be-testuil-only library to be <scope>test in odlparent), and got subsequently already got bitten by it myself, with a build failure in inject-guice-testutils ..

> Proposed fix: https://git.opendaylight.org/gerrit/#/c/48906/

To me that would be the right fix. However, please note that the same was already proposed in https://git.opendaylight.org/gerrit/#/c/48442/, but shot down.. may I let you see with the odlparent committer who at the time had shot that down whether he's more willing to accept your 2nd attempt at the same?

If that still doesn't get accepted, and as an easier and quicker fix local to centinel, you could of course always also do like https://git.opendaylight.org/gerrit/#/c/48445/ - as you thought of in the option 2. of your email "Re: [release] CENTINEL Carbon Autorelease Build Failure".

Generated at Wed Feb 07 19:15:12 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.