[CONTROLLER-1035] Clustering: org.opendaylight.controller.remote.rpc.registry.RpcRegistryTest.testAddRemoveRpcOnSameNode is not stable Created: 20/Nov/14  Updated: 07/Jan/15  Resolved: 07/Jan/15

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: Helium
Fix Version/s: None

Type: Bug
Reporter: Tony Tkacik Assignee: Tom Pantelis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Blocks
blocks MDSAL-55 Topic: Continuos: Decrease technical ... Resolved
External issue ID: 2415

 Description   

Test org.opendaylight.controller.remote.rpc.registry.RpcRegistryTest.testAddRemoveRpcOnSameNode
is not stable and it fails unrelated verify and merge jobs, which increases burden on infrastructure and reviewers.

 Comments   
Comment by Tom Pantelis [ 26/Nov/14 ]

It finally failed after 189 consecutive runs:

-------------------------------------------------------------------------------
Test set: org.opendaylight.controller.remote.rpc.registry.RpcRegistryTest
-------------------------------------------------------------------------------
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.914 sec <<< FAILURE! - in org.opendaylight.controller.remote.rpc.registry.RpcRegistryTest
testRpcAddRemoveInCluster(org.opendaylight.controller.remote.rpc.registry.RpcRegistryTest) Time elapsed: 10.009 sec <<< FAILURE!
java.lang.AssertionError: assertion failed: timeout (10 seconds) during expectMsgClass waiting for class org.opendaylight.controller.remote.rpc.registry.gossip.Messages$BucketStoreMessages$UpdateRemoteBuckets
at scala.Predef$.assert(Predef.scala:179)
at akka.testkit.TestKitBase$class.expectMsgClass_internal(TestKit.scala:423)
at akka.testkit.TestKitBase$class.expectMsgClass(TestKit.scala:419)
at akka.testkit.TestKit.expectMsgClass(TestKit.scala:718)
at akka.testkit.JavaTestKit.expectMsgClass(JavaTestKit.java:408)
at org.opendaylight.controller.remote.rpc.registry.RpcRegistryTest.testRpcAddRemoveInCluster(RpcRegistryTest.java:150)

Comment by Tom Pantelis [ 26/Nov/14 ]

I found the root cause - a timing issue in the tests. After fixing it, the tests ran 900 times without failure.

Comment by Tom Pantelis [ 26/Nov/14 ]

Submitted https://git.opendaylight.org/gerrit/#/c/13151/.

Comment by Moiz Raja [ 02/Dec/14 ]

We need this cherry-picked to stable/helium.

Comment by Tom Pantelis [ 06/Jan/15 ]

Manually cherry picked to helium: https://git.opendaylight.org/gerrit/#/c/13937/

Generated at Wed Feb 07 19:54:31 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.