[CONTROLLER-1052] Upgrade nagasena to 2.50.0 Created: 02/Dec/14  Updated: 19/Jun/15  Resolved: 19/Jun/15

Status: Resolved
Project: controller
Component/s: netconf
Affects Version/s: Post-Helium
Fix Version/s: None

Type: Improvement
Reporter: Robert Varga Assignee: Tomas Cere
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Blocks
blocks CONTROLLER-1053 Reuse EXI codec entities Resolved
blocks CONTROLLER-1139 EXI encode/decode failure with a spec... Resolved
blocks MDSAL-55 Topic: Continuos: Decrease technical ... Resolved

 Description   

We are currently shipping nagasena 2.38.0. Deploy a new artifact based on 2.49.0 and start using it.

 Comments   
Comment by Maros Marsalek [ 02/Jun/15 ]

CONTROLLER-1139 is still present in ODL even with version 2.52 of nagasena lib when we try to reuse the Transmogrifier.

I was able to reproduce the issue in an isolated environment and I have opened a discussion in the openEXI lib forum
https://sourceforge.net/p/openexi/discussion/800031/thread/5a8554bd/#cee3

Not upgrading for now. Will wait for response from openEXI team.

New findings for CONTROLLER-1139:
The bug with decoding EXI (2679) appears only after 2 similar xml messages(same xml tags) are encoded/decoded. The decoding fails for the second message, because the encoding produces different binary output. Example of such similar messages:

// First:
<rpc message-id="m-2" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<edit-config>
<target>
<candidate/>
</target>
<config>
<modules xmlns="urn:opendaylight:params:xml:ns:yang:controller:config">
</modules>
</config>
</edit-config>
</rpc>

// Second:
<rpc message-id="m-3" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<edit-config>
<target>
<candidate/>
</target>
<default-operation>none</default-operation>
<config>
<modules xmlns="urn:opendaylight:params:xml:ns:yang:controller:config">
<module xmlns:a="urn:ietf:params:xml:ns:netconf:base:1.0" a:operation="replace">
<name>example-bgp-peer</name>
<type xmlns:x="urn:opendaylight:params:xml:ns:yang:controller:bgp:rib:impl">x:bgp-peer</type>
</module>
</modules>
</config>
</edit-config>
</rpc>

Comment by Maros Marsalek [ 03/Jun/15 ]

Authors of nagasena/openExi promised to fix this bug in the next release. So we should update to the next available version (after 2.52).

Comment by Tomas Cere [ 17/Jun/15 ]

https://git.opendaylight.org/gerrit/#/c/22681/

Comment by Maros Marsalek [ 19/Jun/15 ]

Just noticed this was not cherry-picked for master. But I cannot change the state of this bug back to waiting for review. These are the cherry-picks:

https://git.opendaylight.org/gerrit/#/c/22972/
https://git.opendaylight.org/gerrit/#/c/22973/

Generated at Wed Feb 07 19:54:34 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.