[CONTROLLER-1114] Remove unnecessary <scm> section from features Created: 19/Jan/15  Updated: 25/Jul/23  Resolved: 04/May/15

Status: Resolved
Project: controller
Component/s: adsal
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Thanh Ha (zxiiro) Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Issue Links:
Blocks
blocks CONTROLLER-1087 Refactor pom.xml files in controller ... Resolved
External issue ID: 2604

 Description   

Remove unnecessary <scm> section from controller features since they should be inherited from a project parent pom. This removes unnecessary duplication of configuration.



 Comments   
Comment by Thanh Ha (zxiiro) [ 19/Jan/15 ]

There's some issues we need to consider with Maven SCM configuration when it is inherited. Maven typically appends the ${artifactId} at the end of the SCM URL so if we don't manage this correctly Maven will end up creating invalid SCM URLs for our poms.

See the following links for details regarding the issue:
http://stackoverflow.com/questions/20513744/project-artifactid-in-parent-pom-xml-resolves-odd
http://jira.codehaus.org/browse/MNG-2290

Comment by Thanh Ha (zxiiro) [ 19/Mar/15 ]

Unfortunately I haven't been able to find a better way to do this through letting the scm section be inherited. Due to the way Maven constructs the paths and the way OpenDaylight parents are inherited sometimes via external parents.

I think we have to live with hardcoding these in each pom in order for them to be accurate.

Closing this as WONTFIX unless anyone's able to figure out a better way to achieve inheritance.

Comment by Carol Sanders [ 04/May/15 ]

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL

Generated at Wed Feb 07 19:54:43 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.