[CONTROLLER-112] Please convert System.out.println usage to proper log statements Created: 15/Jan/14  Updated: 25/Jul/23  Resolved: 05/May/15

Status: Resolved
Project: controller
Component/s: adsal
Affects Version/s: None
Fix Version/s: None

Type: Improvement
Reporter: Ed Warnicke Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Mac OS
Platform: PC


Issue Links:
Blocks
blocks MDSAL-55 Topic: Continuos: Decrease technical ... Resolved

 Description   

Please convert all usages of System.out.println to proper log statements:

Running command: grep -rn System.out .
./opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManagerCLI.java:44: System.out.println("Could not get an handle to the container cluster service:" + container);
./opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManagerCLI.java:48: System.out.println("Could not get cache named:" + cacheName);
./opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManagerCLI.java:52: System.out.println("Could not get cache named:" + cacheName);
./opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManagerCLI.java:58: System.out.println("AdvancedCache retrieved!");
./opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManagerCLI.java:63: System.out.println("Routing Table for the Hash:" + dMgr.getConsistentHash()
./opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManagerCLI.java:65: System.out.println("Get Members:" + dMgr.getConsistentHash()
./opendaylight/clustering/stub/src/test/java/org/opendaylight/controller/clustering/stub/internal/TestClusteringStub.java:134: System.out.println("cache size:" + caches.size());
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/distribution/Sanity.java:23: System.out.println("Current working directory = " + cwd);
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/distribution/Sanity.java:40: copy(p.getInputStream(), System.out);
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/distribution/Sanity.java:44: System.out.println("Test exited with exitValue = " + p.exitValue());
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:54: System.out.println("------ Failed to activate/resolve fragment = " + bundle.getSymbolicName() + " state = " + stateToString(bundle.getState()));
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:61: System.out.println("------ Failed to activate/resolve bundle = " + bundle.getSymbolicName() + " state = " + stateToString(bundle.getState()));
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:71: System.out.println("all bundles haven't finished starting, will repeat");
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:75: System.out.println("Thread.sleep interuptted.");
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:84: System.out.flush();
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:85: System.out.println("exiting with 1 as failed");
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:86: System.out.close();
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:89: System.out.flush();
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:90: System.out.println("exiting with 0 as succeeded");
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java:91: System.out.close();
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:49: System.out.println("Cannot find the FRM instance on container: " + container);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:53: System.out.println("Group " + group);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:56: System.out.println(flowEntry.getNode() + " " + flowEntry.getFlowName());
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:58: System.out.println(flowEntry.getNode() + " " + flowEntry.toString());
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:69: System.out.println("Cannot find the FRM instance on container: " + container);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:73: System.out.println("Group " + group);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:76: System.out.println(flowEntry.getNode() + " " + flowEntry.getFlowName());
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:78: System.out.println(flowEntry.getNode() + " " + flowEntry.toString());
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:91: System.out.println("Cannot find the FRM instance on container: " + container);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:96: System.out.println("Please enter a valid node id");
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:100: System.out.println("Node " + nodeId);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:103: System.out.println(flowEntry.getNode() + " " + flowEntry.getFlowName());
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:105: System.out.println(flowEntry.getNode() + " " + flowEntry.toString());
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:118: System.out.println("Cannot find the FRM instance on container: " + container);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:123: System.out.println("Please enter a valid node id");
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:127: System.out.println("Node " + nodeId);
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:130: System.out.println(flowEntry.getNode() + " " + flowEntry.getFlowName());
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java:132: System.out.println(flowEntry.getNode() + " " + flowEntry.toString());
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/FRMConsumerImpl.java:43: System.out.println("Unable to fetch handlers for dependent modules");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/FRMConsumerImpl.java:64: System.out.println("Data Broker Service is down or NULL.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/FRMConsumerImpl.java:69: System.out.println("Data Broker Service is down or NULL.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/FRMConsumerImpl.java:73: System.out.println("Notification Service is down or NULL.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/FRMConsumerImpl.java:77: System.out.println("Consumer session is NULL. Please check if provider is registered");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/GroupConsumerImpl.java:74: System.out.println("Consumer SAL Group Service is down or NULL.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/GroupConsumerImpl.java:83: System.out.println("Listener to listen on group data modifcation events.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/MeterConsumerImpl.java:77: System.out.println("Consumer SAL Meter Service is down or NULL.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/MeterConsumerImpl.java:86: System.out.println("Listener to listen on meter data modifcation events.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/TableFeaturesConsumerImpl.java:45: System.out.println("Consumer SAL Service is down or NULL.");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/TableFeaturesConsumerImpl.java:49: System.out.println("-------------------------------------------------------------------");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/TableFeaturesConsumerImpl.java:84: System.out.println("Coming update cc in TableDatacommitHandler");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/TableFeaturesConsumerImpl.java:96: System.out.println("Coming in TableFeaturesDatacommitHandler");
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/TableFeaturesConsumerImpl.java:150: System.out.println("Coming update in TableFeaturesDatacommitHandler");
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:411: ////System.out.println("«type.name»#deserialize: " +$1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:495: ////System.out.println("Qname " + $1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:496: ////System.out.println("Value " + $2);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:502: ////System.out.println("«signature.key»" + value.«signature.key»());
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:531: System.out.println(_localQName + " " + _compositeNode);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:591: ////System.out.println("«typeSpec.name»#toDomStatic: " + _ret);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:679: System.out.println(_localQName + " " + _compositeNode);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:695: System.out.println(_localQName + " " + _compositeNode);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:711: System.out.println(_localQName + " " + _compositeNode);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:744: ////System.out.println("Aug. key:" + _entry.getKey());
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:758: ////System.out.println("«propertyName»#deCode"+dom«propertyName»);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:767: ////System.out.println(" item" + _listItem);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:769: ////System.out.println(" value" + _value);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:775: ////System.out.println(" list" + «propertyName»);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:864: ////System.out.println("«inputType.simpleName»#toDomValue: "+$1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:870: ////System.out.println("«inputType.simpleName»#toDomValue:Enc: "+_encapsulatedValue);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:872: ////System.out.println("«inputType.simpleName»#toDomValue:DeEnc: "+_value);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:889: ////System.out.println("«inputType.simpleName»#fromDomValue: "+$1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:938: ////System.out.println("«inputType.simpleName»#toDomValue: "+$1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:969: ////System.out.println("«inputType.simpleName»#fromDomValue: "+$1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:1018: ////System.out.println("«inputType.simpleName»#toDomValue: "+$1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:1025: //System.out.println("«inputType.simpleName»#toDomValue:Enc: "+_encapsulatedValue);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:1034: //System.out.println("«inputType.simpleName»#toDomValue:DeEnc: "+_domValue);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:1052: //System.out.println("«inputType.simpleName»#fromDomValue: "+$1);
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:1340: ////System.out.println("«type.name»#«signature.key»" + value.«signature.key»());
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend:1382: ////System.out.println("«propertyName»:" + «propertyName»);
./opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/PutAugmentationTest.java:128: System.out.println("Before assertion");
./opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java:161: // System.out.println("Merge time: " + ((System.nanoTime() -
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoConsumerImpl.java:41: System.out.println(name
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoConsumerImpl.java:60: System.out.println(name
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoProviderImpl.java:43: System.out.println("Provider: Error: Session not available");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoProviderImpl.java:44: System.out
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoProviderImpl.java:57: System.out.println("Provider: Error: Session not available");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoProviderImpl.java:58: System.out
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:41: System.out.print("\nEnter your choice (0 - list): ");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:76: System.out.println("Please enter valid input.");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:80: System.out
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:83: System.out.println(" Message: " + e.getMessage());
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:102: System.out.print("Please enter notification content:");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:108: System.out.print("Please enter notification content:");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:126: System.out.println("Usage: ");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:127: System.out.println(" 0) Display Help");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:128: System.out.println(" 1) Register Provider");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:129: System.out.println(" 2) Register Consumer 1 (listening on alert)");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:130: System.out
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:132: System.out.println(" 4) Send Alert Notification");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:133: System.out.println(" 5) Send Change Notification");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:134: System.out.println(" 6) Unregister Consumer 1");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:135: System.out.println(" 7) Unregister Consumer 2");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:136: System.out.println(" 8) Unregister Provider");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:137: System.out.println(" 9) Exit");
./opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java:146: System.out.println("Initializing broker");
./opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/json/test/CnSnToJsonIdentityrefTest.java:58: System.out.println(json);
./opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/ReadConfAndOperDataTest.java:64: System.out.println(l.getMessage());
./opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/XmlProvidersTest.java:77: System.out.println(l.getMessage());
./opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/NetconfMappingTest.java:263: // System.out.println(responseFromCandidate);
./opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/NetconfMappingTest.java:266: // System.out.println(responseFromRunning);
./opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/NetconfMonitoringITTest.java:178: System.out.println(responseBuilder.toString());
./opendaylight/netconf/netconf-monitoring/src/test/java/org/opendaylight/controller/netconf/monitoring/xml/JaxBSerializerTest.java:54: System.out.println(XmlUtil.toString(xml));
./opendaylight/northbound/bundlescanner/implementation/src/test/java/org/opendaylight/controller/northbound/bundlescanner/internal/BundleScannerTest.java:56: System.out.println("==== " + testName.getMethodName());
./opendaylight/northbound/bundlescanner/implementation/src/test/java/org/opendaylight/controller/northbound/bundlescanner/internal/BundleScannerTest.java:85: System.out.println("name:" + name + " classes:" + classes.size());
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:142: System.out.println("HTTP method: " + method + " url: " + restUrl.toString());
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:144: System.out.println("body: " + body);
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:186: System.out.println("HTTP response code: " + response.getStatus());
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:187: System.out.println("HTTP response message: " + response.getEntity());
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:269: System.out.println("Starting Subnets JAXB client.");
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:412: System.out.println("Starting StaticRouting JAXB client.");
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:493: System.out.println("Starting SwitchManager JAXB client.");
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:643: System.out.println("Starting Statistics JAXB client.");
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:835: System.out.println("Starting FlowProgrammer JAXB client.");
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:954: System.out.println("Starting HostTracker JAXB client.");
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:1135: System.out.println("Starting Topology JAXB client.");
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:1177: System.out.println("Get Topology: " + result);
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:1248: System.out.println("result:" + result);
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java:1299: System.out.println("result:" + result);
./opendaylight/northboundtest/unit_test_suite/src/main/java/org/opendaylight/controller/northboundtest/unittestsuite/internal/API3UnitTest.java:134: System.out.println(line);
./opendaylight/northboundtest/unit_test_suite/src/main/java/org/opendaylight/controller/northboundtest/unittestsuite/internal/API3UnitTest.java:147: System.out.println("Exception!");
./opendaylight/northboundtest/unit_test_suite/src/main/java/org/opendaylight/controller/northboundtest/unittestsuite/internal/API3UnitTest.java:199: System.out.println("Exception!");
./opendaylight/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementationCLI.java:52: System.out.println("Cannot find the routing instance on container:" + container);
./opendaylight/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementationCLI.java:60: System.out.println("Route between srcNode:" + src + " and dstNode:" + dst + " = " + p);
./opendaylight/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementationCLI.java:62: System.out.println("There is no route between srcNode:" + src + " and dstNode:" + dst);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/DijkstraTest.java:90: System.out.println("Actual Res is " + res);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/DijkstraTest.java:91: System.out.println("Expected Res is " + expectedRes);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/DijkstraTest.java:163: System.out.println("Actual Res is " + res);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/DijkstraTest.java:164: System.out.println("Expected Res is " + expectedRes);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/DijkstraTest.java:240: System.out.println("Actual Res is " + res);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/DijkstraTest.java:241: System.out.println("Expected Res is " + expectedRes);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/MaxThruputTest.java:199: System.out.println("Max Thruput Path between n1-n3: " + res);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/MaxThruputTest.java:214: System.out.println("Actual Res is " + res);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/MaxThruputTest.java:215: System.out.println("Expected Res is " + expectedRes);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/MaxThruputTest.java:220: System.out.println("Shortest Path between n1-n3: " + res);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/MaxThruputTest.java:232: System.out.println("Actual Res is " + res);
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/MaxThruputTest.java:233: System.out.println("Expected Res is " + expectedRes);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:40: System.out.println("Got exception as expected!:" + e);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:60: System.out.println("Got exception as expected!:" + e);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:80: System.out.println("Got exception as expected!:" + e);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:95: System.out.println("Got node:" + of1);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:114: System.out.println("Got node:" + onepk1);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:133: System.out.println("Got node:" + pcep1);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:595: System.out.println("NodeConnector String = " + nc1Str);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:616: System.out.println("NodeConnector String = " + nc1Str);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:637: System.out.println("NodeConnector String = " + nc1Str);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:658: System.out.println("NodeConnector String = " + nc1Str);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:679: System.out.println("NodeConnector String = " + nc1Str);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:700: System.out.println("NodeConnector String = " + nc1Str);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:722: System.out.println("NodeConnector String = " + nc1Str);
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java:743: System.out.println("NodeConnector Strin...



 Comments   
Comment by Sahil Shah [ 18/Jan/14 ]

Hi Ed,
Please update if we have to make the changes in the unit test and integration test files also apart from the other java files.

-Sahil

Comment by Giovanni Meo [ 23/Jan/14 ]

For the following files:
---------------------------------
opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManagerCLI.java
opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java
opendaylight/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementationCLI.java
opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManagerCLI.java

are used in CLI hence the output has to be given back to user interactively.

The follow file in only used in integration tests so output has to be given interactively:
---------------------------------
opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/sanitytest/internal/Activator.java

The follow file are only used in demo code hence output has to be given interactively:
---------------------------------
opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoConsumerImpl.java
opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/DemoProviderImpl.java
opendaylight/md-sal/sal-dom-demo/src/main/java/org/opendaylight/controller/sal/demo/SALDemo.java

Comment by Jyotsna Priya [ 23/Jan/14 ]

Hi Giovanni,

Apart from the files mentioned by you, the rest of the files can be divided into three categories: *Impl.java, *.xtend and *Test.java

*Test.java files are:
./opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/PutAugmentationTest.java
./opendaylight/clustering/stub/src/test/java/org/opendaylight/controller/clustering/stub/internal/TestClusteringStub.java
./opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/json/test/CnSnToJsonIdentityrefTest.java
./opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/ReadConfAndOperDataTest.java
./opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/XmlProvidersTest.java
./opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/NetconfMappingTest.java
./opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/NetconfMonitoringITTest.java
./opendaylight/netconf/netconf-monitoring/src/test/java/org/opendaylight/controller/netconf/monitoring/xml/JaxBSerializerTest.java
./opendaylight/northbound/bundlescanner/implementation/src/test/java/org/opendaylight/controller/northbound/bundlescanner/internal/BundleScannerTest.java
./opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java
./opendaylight/northboundtest/unit_test_suite/src/main/java/org/opendaylight/controller/northboundtest/unittestsuite/internal/API3UnitTest.java
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/DijkstraTest.java
./opendaylight/routing/dijkstra_implementation/src/test/java/org/opendaylight/controller/routing/dijkstra_implementation/MaxThruputTest.java
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeConnectorTest.java
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeTableTest.java
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/NodeTest.java
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PropertyTest.java
./opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/packet/ARPTest.java

Again these files are used in tests so output has to be given interactively. So changes are not required.

*.xtend file is:
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend

and *Impl.java files are:
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/TableFeaturesConsumerImpl.java
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/MeterConsumerImpl.jav
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/GroupConsumerImpl.java
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/FRMConsumerImpl.java

Please suggest if changes in *Impl.java and *.xtend files are required or not.

-Jyotsna

Comment by Giovanni Meo [ 23/Jan/14 ]

Hi Jyotsna,

the files:

*.xtend file is:
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend

and *Impl.java files are:
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/TableFeaturesConsumerImpl.java
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/MeterConsumerImpl.jav
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/GroupConsumerImpl.java
./opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/forwardingrulesmanager/consumer/impl/FRMConsumerImpl.java

are required to be changed, these are used at runtime.

Thanks,
Giovanni

Comment by Jyotsna Priya [ 28/Jan/14 ]

As per the comments on https://git.opendaylight.org/gerrit/#/c/4675/ , none of the files require any change. So this bug should be closed.

Comment by Tony Tkacik [ 13/Nov/14 ]

Added as blocking issue for Topic: Decrease Technical Debt.

Comment by Carol Sanders [ 04/May/15 ]

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL

Generated at Wed Feb 07 19:52:13 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.