[CONTROLLER-1126] Websocket notifications: No notification received when data are removed Created: 26/Jan/15  Updated: 16/Mar/15  Resolved: 16/Mar/15

Status: Resolved
Project: controller
Component/s: restconf
Affects Version/s: Helium
Fix Version/s: None

Type: Bug
Reporter: Milos Fabian Assignee: Jan Hajnar
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC

External issue ID: 2642
Priority: High

 Description   

Tested data change notifications (via websockets, pcep-topology) - subscribed on network-topology

<input xmlns="urn:opendaylight:params:xml:ns:yang:controller:md:sal:remote">
<path xmlns:a="urn:TBD:params:xml:ns:yang:network-topology">/a:network-topology</path>
<datastore xmlns="urn:sal:restconf:event:subscription">OPERATIONAL</datastore>
<scope xmlns="urn:sal:restconf:event:subscription">SUBTREE</scope>
</input>

When data were created (added node to topology - pcc-mock connected), notification was send & received on client side. However when data were deleted (topology node was removed, pcc-mock disconnected), no notification was received.

 Comments   
Comment by Dana Kutenicsova [ 06/Feb/15 ]

ERROR | DOM-OPER-DCL-9 | QueuedNotificationManager | 78 - org.opendaylight.yangtools.util - 0.6.4.Helium-SR2 | DataChangeListenerQueueMgr: Error notifying listener AbstractObjectRegistration

{instance=or g.opendaylight.controller.sal.streams.listeners.ListenerAdapter@4bb7b162}

java.lang.UnsupportedOperationException: Augmentation node has no QName
at org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$AugmentationIdentifier.getNodeType(YangInstanceIdentifier.java:632)[108:org.opendaylight.yangtools.yang-data-api:0.6.4.Helium-SR2]
at org.opendaylight.controller.sal.streams.listeners.ListenerAdapter.addPathAsValueToElement(ListenerAdapter.java:437)[237:org.opendaylight.controller.sal-rest-connector:1.1.2.Helium-SR2]
at org.opendaylight.controller.sal.streams.listeners.ListenerAdapter.createDataChangeEventElement(ListenerAdapter.java:372)[237:org.opendaylight.controller.sal-rest-connector:1.1.2.Helium-SR2]
at org.opendaylight.controller.sal.streams.listeners.ListenerAdapter.addValuesFromDataToElement(ListenerAdapter.java:322)[237:org.opendaylight.controller.sal-rest-connector:1.1.2.Helium-SR2]
at org.opendaylight.controller.sal.streams.listeners.ListenerAdapter.addValuesToDataChangedNotificationEventElement(ListenerAdapter.java:292)[237:org.opendaylight.controller.sal-rest-connector:1.1.2.Helium-SR2]
at org.opendaylight.controller.sal.streams.listeners.ListenerAdapter.prepareXmlFrom(ListenerAdapter.java:233)[237:org.opendaylight.controller.sal-rest-connector:1.1.2.Helium-SR2]
at org.opendaylight.controller.sal.streams.listeners.ListenerAdapter.onDataChanged(ListenerAdapter.java:104)[237:org.opendaylight.controller.sal-rest-connector:1.1.2.Helium-SR2]
at org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore$1.invokeListener(InMemoryDOMDataStore.java:74)[171:org.opendaylight.controller.sal-inmemory-datastore:1.1.2.Helium-SR2]
at org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore$1.invokeListener(InMemoryDOMDataStore.java:68)[171:org.opendaylight.controller.sal-inmemory-datastore:1.1.2.Helium-SR2]
at org.opendaylight.yangtools.util.concurrent.QueuedNotificationManager$NotificationTask.notifyListener(QueuedNotificationManager.java:411)[78:org.opendaylight.yangtools.util:0.6.4.Helium-SR2]
at org.opendaylight.yangtools.util.concurrent.QueuedNotificationManager$NotificationTask.run(QueuedNotificationManager.java:382)[78:org.opendaylight.yangtools.util:0.6.4.Helium-SR2]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)[:1.7.0_51]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)[:1.7.0_51]
at java.lang.Thread.run(Thread.java:744)[:1.7.0_51]

Comment by Jan Hajnar [ 09/Feb/15 ]

thanks for the log message. Problem seems to be caused by augmentations in data change event path.

quick fix for helium:
https://git.opendaylight.org/gerrit/#/c/15062/

Comment by Jan Hajnar [ 05/Mar/15 ]

this fix is also part of this commit for master:
https://git.opendaylight.org/gerrit/#/c/15948/

Generated at Wed Feb 07 19:54:45 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.