[CONTROLLER-13] ForwardingRulesManager.addEntriesInternal has addFlow and addFlowAsync reversed Created: 03/May/13  Updated: 05/May/15  Resolved: 05/May/15

Status: Resolved
Project: controller
Component/s: adsal
Affects Version/s: 0.4.0
Fix Version/s: None

Type: Bug
Reporter: Kalvin Hom Assignee: Kalvin Hom
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 16

 Description   

In ForwardingRulesManager.addEntriesInternal

// Install the flow on the network node
Status status = (async)?
programmer.addFlowAsync(entry.getNode(), entry.getInstall()
.getFlow()) :
programmer.addFlow(entry.getNode(), entry.getInstall()
.getFlow());

The asynchronous and normal call is reversed.

 Comments   
Comment by Kalvin Hom [ 03/May/13 ]

(In reply to comment #0)
> In ForwardingRulesManager.addEntriesInternal
>
> // Install the flow on the network node
> Status status = (async)?
> programmer.addFlowAsync(entry.getNode(), entry.getInstall()
> .getFlow()) :
> programmer.addFlow(entry.getNode(), entry.getInstall()
> .getFlow());
>
> The asynchronous and normal call is reversed.

The comment above showed the fix...not it being reversed.

Comment by Carol Sanders [ 05/May/15 ]

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL.

Generated at Wed Feb 07 19:51:58 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.