[CONTROLLER-1505] OutOfMemoryError in YangStoreSnapshot Created: 30/Mar/16 Updated: 25/Jul/23 Resolved: 31/Mar/16 |
|
| Status: | Resolved |
| Project: | controller |
| Component/s: | config |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Tom Pantelis | Assignee: | Tom Pantelis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 5625 |
| Description |
|
I've observed OutOfMemoryError in YangStoreSnapshot while pushing a config: Exception in thread "config-pusher" java.lang.OutOfMemoryError This is reproducible if you change or add an invalid required capability so it retries. After a period of time the OutOfMemoryError will occur. This is caused by a resource leak in YangStoreSnapshot getModuleSource - it doesn't close the InputStream returned via yangTextSchemaSource.openStream(). I think this error can also occur for valid configs if there are enough of them but it definitely occurs with failure retries. |
| Comments |
| Comment by Tom Pantelis [ 30/Mar/16 ] |
| Comment by Tom Pantelis [ 30/Mar/16 ] |
|
Looks like the offending code was added in Be so we'll need to cherry-pick. |
| Comment by Robert Varga [ 31/Mar/16 ] |