[CONTROLLER-159] Flow statistics model do not have a notion of a multi-part transaction Created: 13/Feb/14  Updated: 25/Jul/23  Resolved: 19/Feb/14

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: None
Fix Version/s: None

Type: Improvement
Reporter: Robert Varga Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All



 Description   

The way the various statistics notifications are modeled is that they each define a moreReplies leaf:

notification flows-statistics-update {
description "Flows statistics sent by switch";
leaf moreReplies

{ type boolean; }

uses inv:node;
uses flow-and-statistics-map-list;
uses tr:transaction-aware;
}

now this makes it quite clunky in the stats manager code, where each instantiation needs to pass that one bit down. Correct way of doing this would be to introduce a multipart-transaction-aware concepts:

grouping multipart-transaction-aware {
uses tr:transaction-aware;
leaf moreReplies

{ type boolean; default false; }

}

and use that in the stats, like this:

notification flows-statistics-update

{ description "Flows statistics sent by switch"; uses inv:node; uses flow-and-statistics-map-list; uses tr:multipart-transaction-aware; }

 Comments   
Comment by Tony Tkacik [ 19/Feb/14 ]

Fixed in https://git.opendaylight.org/gerrit/#/c/5333/

Generated at Wed Feb 07 19:52:20 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.