Operating System: Mac OS
Platform: Macintosh

Hi David,
deserialization exception is logged because no Binding Aware Component is actually listening or participating in that put operation, thus no codecs exist (since no-one needs that data).

The exception itself is bit confusing, so I would suggest improving error reporting, that no-one is actually listening to that data, rather then showing exception (this exception is correct state), but confuses people that something is broken inside MD-SAL.

So presumably what is happening is that after the data is put into the config store, the SAL wants to send a notification to anyone listening that the config data has changed.

Either the SAL knows that no one has registered to listen, in which case it would not need to deserialize the data or the SAL is blind to the list of listeners and thus needs to deserialize the data an attempt to send an event that no one receives.

If the SAL knows no one is listening, then I would think no deserialization would ever take place, it could just issue an error / warning because some configuration data was pushed that will never be used.

If the SAL is not aware then I can see that it might attempt to deserialize the data depending on the code path, but I am not sure why that would cause an exception. Presumably the Java DTO objects can be found that represent the data and thus the data could be mashalled into those objects.

So I guess the question is, what is being deserialized that causes the failures? I haven't walked this with the debugger yet, as my assumption was this was related to the other bugs with serialization around the toaster example.

I agree a warning or error indicating no one is listening and the data is essentially unused is valid.

So I added a data provider listener to the toaster example and attempted a put, now I am getting the below exception, so i still think there may a bug here.

2014-02-21 11:48:09.187 PST [pool-20-thread-4] ERROR o.o.c.s.b.i.c.d.BindingIndependentConnector - Ommiting from BA transaction: /(http://netconfcentral.org/ns/toaster?revision=2009-11-20)toaster.
org.opendaylight.yangtools.yang.data.impl.codec.DeserializationException: java.lang.ClassCastException: java.lang.String cannot be cast to org.opendaylight.yang.gen.v1.http.netconfcentral.org.ns.toaster.rev091120.Toaster$ToasterStatus
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl.tryDeserialization(RuntimeGeneratedMappingServiceImpl.java:455) ~[bundlefile:na]
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl.dataObjectFromDataDom(RuntimeGeneratedMappingServiceImpl.java:597) ~[bundlefile:na]
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl.dataObjectFromDataDom(RuntimeGeneratedMappingServiceImpl.java:423) ~[bundlefile:na]
at org.opendaylight.controller.config.yang.md.sal.binding.impl.RuntimeMappingModule$RuntimeGeneratedMappingServiceProxy.dataObjectFromDataDom(RuntimeMappingModule.java:135) ~[bundlefile:na]
at org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentConnector.createDomToBindingTransaction(BindingIndependentConnector.java:240) [bundlefile:na]
at org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentConnector.access$900(BindingIndependentConnector.java:93) [bundlefile:na]
at org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentConnector$DomToBindingCommitHandler.requestCommit(BindingIndependentConnector.java:504) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:90) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:38) [bundlefile:na]
at java.util.concurrent.FutureTask.run(FutureTask.java:262) [na:1.7.0_51]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [na:1.7.0_51]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [na:1.7.0_51]
at java.lang.Thread.run(Thread.java:744) [na:1.7.0_51]
Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to org.opendaylight.yang.gen.v1.http.netconfcentral.org.ns.toaster.rev091120.Toaster$ToasterStatus
at org.opendaylight.yang.gen.v1.http.netconfcentral.org.ns.toaster.rev091120.Toaster$Broker$Codec$DOM.fromDomStatic(Toaster$Broker$Codec$DOM.java) ~[na:na]
at org.opendaylight.yang.gen.v1.http.netconfcentral.org.ns.toaster.rev091120.Toaster$Broker$Codec$DOM.deserialize(Toaster$Broker$Codec$DOM.java) ~[na:na]
at org.opendaylight.yangtools.sal.binding.generator.impl.LazyGeneratedCodecRegistry$DataContainerCodecImpl.deserialize(LazyGeneratedCodecRegistry.java:545) ~[bundlefile:na]
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl$11.call(RuntimeGeneratedMappingServiceImpl.java:588) ~[bundlefile:na]
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl$11.call(RuntimeGeneratedMappingServiceImpl.java:580) ~[bundlefile:na]
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl.tryDeserialization(RuntimeGeneratedMappingServiceImpl.java:450) ~[bundlefile:na]
... 12 common frames omitted

Other ways to reproduce:

2014-03-13 15:12:35 PDT [org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/restconf].[JAXRSRestconf]] SEVERE org.apache.catalina.core.StandardWrapperValve invoke Servlet.service() for servlet [JAXRSRestconf] in context with path [/restconf] threw exception [java.util.concurrent.ExecutionException: java.lang.IllegalStateException:
If a YANG Model contains a leaf of type enumeration, like this:

leaf node-connector-type {
type enumeration {
enum "CTRL"

enum "ALL"

And the value is passed in via RestConf as let's say "ALL", then YANGTools fails with the following ClassCastException.

org.opendaylight.yangtools.yang.data.impl.codec.DeserializationException: java.lang.ClassCastException: java.lang.String cannot be cast to org.opendaylight.yang.gen.v1.urn.opendaylight.host.tracker.rev140305.host.NodeConnector$NodeConnectorType] with root cause
java.lang.ClassCastException: java.lang.String cannot be cast to org.opendaylight.yang.gen.v1.urn.opendaylight.host.tracker.rev140305.host.NodeConnector$NodeConnectorType
at org.opendaylight.yang.gen.v1.urn.opendaylight.host.tracker.rev140305.host.NodeConnector$Broker$Codec$DOM.fromDomStatic(NodeConnector$Broker$Codec$DOM.java)
at org.opendaylight.yang.gen.v1.urn.opendaylight.host.tracker.rev140305.AddStaticHostInput$Broker$Codec$DOM.fromDomStatic(AddStaticHostInput$Broker$Codec$DOM.java)
at org.opendaylight.yang.gen.v1.urn.opendaylight.host.tracker.rev140305.AddStaticHostInput$Broker$Codec$DOM.deserialize(AddStaticHostInput$Broker$Codec$DOM.java)
at org.opendaylight.yangtools.sal.binding.generator.impl.LazyGeneratedCodecRegistry$DataContainerCodecImpl.deserialize(LazyGeneratedCodecRegistry.java:629)
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl$11.call(RuntimeGeneratedMappingServiceImpl.java:590)
at org.opendaylight.yangtools.sal.binding.generator.impl.RuntimeGeneratedMappingServiceImpl$11.call(RuntimeGeneratedMappingServiceImpl.java:582

With new default datastore this does not happen.