[CONTROLLER-1765] trace:transactions should suppress false TransactionChain positives, by white list, or showing only x2+ ? Created: 31/Aug/17  Updated: 25/Jul/23  Resolved: 31/Jul/18

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: None
Fix Version/s: Fluorine

Type: Improvement
Reporter: Michael Vorburger Assignee: Michael Vorburger
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Issue Links:
Blocks
blocks NETVIRT-1089 Add trace:transactions to suite teard... In Progress
blocks NETVIRT-883 Umbrella parent issue for grouping al... Resolved
is blocked by CONTROLLER-1760 Tooling to find the real root cause c... Resolved
is blocked by NETCONF-462 TransactionChain created in RestConne... Resolved

 Description   

The new tool from CONTROLLER-1760 can show "some false positives", as discussed in NETCONF-462 ...



 Comments   
Comment by Michael Vorburger [ 31/Aug/17 ]

+Tom, if you want to chime in here:

I'm leaning towards implementing the solution to suppress all open TransactionChains that are only x1 and only start showing x2+ from trace:transactions... but ONLY for TransactionChain, NOT for the Read[Write]Transaction! Maybe with a -a kind of CLI flag, to be able to see "all", if you really want to. Thoughts, approvals, objections?

Comment by Michael Vorburger [ 11/Apr/18 ]

OPNFLWPLUG-982 seems to say that there are cases where we should ignore and therefore be able to whitelist some known false positives (perhaps by stack trace content, just via String contains) ... so perhaps trace:transactions could have new arguments to ignore <N "leaks" or containing Strings.

Comment by Michael Vorburger [ 28/May/18 ]

https://git.opendaylight.org/gerrit/#/c/72362/ is adding sorting, which helps in spotting the bad from the harmless more easily.

Comment by Michael Vorburger [ 30/Jul/18 ]

This has come up in NETVIRT-1089 again... it's hard for a fully automated (CSIT) test to programmatically know / distinguish when there is a real problem.

I'll therefore add a new option to that CLI command to suppress leaks with less than N (option) open TXs.

Comment by Michael Vorburger [ 30/Jul/18 ]

https://git.opendaylight.org/gerrit/#/c/74652/ should do the trick... Once that is merged, jluhrsen can use it in NETVIRT-1089 with some "sensible value" (7 ?) for the new minOpenTransactions option to trace:transactions, and we're done here.

Generated at Wed Feb 07 19:56:24 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.