[CONTROLLER-1802] Reduce ConcurrentDOMDataBroker TX failure logging from WARN to DEBUG and add @CheckReturnValue to WriteTransaction submit() Created: 11/Dec/17  Updated: 31/Jul/18  Resolved: 06/May/18

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: None
Fix Version/s: Fluorine

Type: Bug Priority: Highest
Reporter: Michael Vorburger Assignee: Michael Vorburger
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to CONTROLLER-1855 Controller should not error log any O... Resolved
relates to TSC-100 WriteTransaction.submit() to be annot... Resolved

 Description   

Motivated by NETVIRT-916, but much more widely applicable in general, and based on https://lists.opendaylight.org/pipermail/controller-dev/2017-December/014100.html, we should reduce the ConcurrentDOMDataBroker's TX failure logging from WARN to DEBUG, and add @CheckReturnValue to WriteTransaction submit(), because it should be up to the caller to decide whether or not to log this at as a WARN, ERROR or not at all (e.g. if it is going to retry).

 Comments   
Comment by Michael Vorburger [ 11/Dec/17 ]

https://git.opendaylight.org/gerrit/#/q/topic:CONTROLLER-1802 does the needful.

PS: What's still TBD is the equivalent of c/66362 in mdsal, or is there no such thing?

Comment by Michael Vorburger [ 11/Dec/17 ]

PS: What's still TBD is the equivalent of c/66362 in mdsal, or is there no such thing?

forget about this, according to https://lists.opendaylight.org/pipermail/controller-dev/2017-December/014102.html : "ConcurrentDOMDataBroker is CDS's broker implementation
(sal-distributed-datastore) and is the one used in production.", so we're all good and already "done" here (when all is merged).

Comment by Michael Vorburger [ 27/Feb/18 ]

We discussed this in today's Kernel Projects call (MoM link), and the plan is:

  1. set up a Weather Item describing 2. - 4.
  2. wait for a blue autorelease-release-fluorine
  3. merge c/66360 into controller master (and c/66361in mdsal, but that's not used, yet)
  4. watch autorelease-release-fluorine for any FindBugs failures, and help to promptly fix them, e.g. by using org.opendaylight.infrautils.utils.concurrent.JdkFutures's addErrorLogging()
Generated at Wed Feb 07 19:56:29 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.