[CONTROLLER-1808] Toaster yang module is incompatible with the netconf central one Created: 18/Jan/18 Updated: 19/Jul/18 Resolved: 19/Jul/18 |
|
| Status: | Resolved |
| Project: | controller |
| Component/s: | documentation |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Low |
| Reporter: | Vratko Polak | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
git repository |
||
| Description |
|
Netconf central has a repository of official yang modules. It contains [0] a module "toaster" revision "2009-11-20". "Compatible copies" can be found in other repositories, for example [1] adds (without updating revision) a comment section with the original MIB. ODL controller repository contains (still in master and at least since helium) [2] a yang module with the same name and revision, but with different structure. Moreover, the netconf central module contains Copyright claim in its description, and if ODL toaster has started as a copy of the netconf central one, it would violate the copyright (because it requires edited copies to contain the copyright notice, but ODL toaster does not contain the copyright). But ODL has definitely made [5] the aforementioned incompatible changes (as enhancements [6]), so now there are two incompatible toaster modules available to general public, which is bad. One possible fix is to rename the ODL variant to odl-toaster. [0] http://www.netconfcentral.org/modulereport/toaster [3] https://github.com/YangModels/yang/blob/master/experimental/odp/toaster.yang [6] https://jira.opendaylight.org/browse/CONTROLLER-365 |
| Comments |
| Comment by Tom Pantelis [ 19/Jul/18 ] |
|
ODL's toaster model was modified 4+ years ago to expand the toaster example. No one complained or had an issue with it then (when the ODL community was much larger) - why would this be an issue now and who actually cares... |