Operating System: All
Platform: All

The contract of MD-SAL requires QNames always contain information according to the schema: this means namespace, revision, local-name.

If this is not present, MD-SAL could not distinguish between two different revisions and thus do the correct processing.

ZeroMQ should send QNames with revision, also all data upstreamed to MD-SAL
should contain revision information. Otherwise MD-SAL is not able to process that.

If you are using w3c Document as payload and XmlDocumentUtils to convert it to yang data - consider using SchemaService from ProviderContext to learn the schema, and then use corresponding methods
from XmlDocumentUtils which takes DataSchemaNode or SchemaContext as argument for normalization (and verification)of XmlDocument.

Abhishek please provide additional information which serialization / deserialization method are you using.

Tony,

Ser/DSer code is in this class:
org.opendaylight.controller.sal.connector.remoterpc.util.XmlUtils

Let me know if this is not appropriate.

Copy/Pasting the code:

public static String compositeNodeToXml(CompositeNode cNode){
if (cNode == null) return new String();

Document domTree = NodeUtils.buildShadowDomTree(cNode);
StringWriter writer = new StringWriter();
try

catch (TransformerException e)

return writer.toString();
}

public static CompositeNode xmlToCompositeNode(String xml){
if (xml==null || xml.length()==0) return null;

Node<?> dataTree;
try

catch (XMLStreamException e)

if (dataTree == null)

if (dataTree instanceof SimpleNode)

return (CompositeNode) dataTree;
}

Hi Tony,

We followed your suggestions in the CONTROLLER-185 notes to use XMLDocumentUtil methods for serialization, deserialization. We first get the ProviderSession, then get SchemaService from it, and get SchemaContext from the SchemaService.
We tried using following methods

public static Document toDocument(CompositeNode data, DataNodeContainer schema, XmlCodecProvider codecProvider) (for converting CompositeNode to XML Document, and that works fine

But other way round we used following method, as that was the only suitable option

public static Node<?> toDomNode(Element xmlElement, Optional<DataSchemaNode> schema,
Optional<XmlCodecProvider> codecProvider) {

But it seems this method at
checkQName(xmlElement, schema.getQName());

Since the qName of both parameters are not equal. Following is the code which calls respective methods of XMLDocumentUtils, see the red highlighted lines. We need your guidance on how to proceed further, or is there any other method from XMLDocumentUtils that you had in mind?
We saw that toCompositeNodeWithSchema is private and can't be used.

/*

• Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved.
  *
• This program and the accompanying materials are made available under the
• terms of the Eclipse Public License v1.0 which accompanies this distribution,
• and is available at http://www.eclipse.org/legal/epl-v10.html
  */

package org.opendaylight.controller.sal.connector.remoterpc.util;

import java.io.IOException;
import javax.xml.parsers.ParserConfigurationException;
import javax.activation.UnsupportedDataTypeException;
import org.opendaylight.yangtools.yang.data.api.CompositeNode;
import org.opendaylight.yangtools.yang.data.api.Node;
import org.opendaylight.yangtools.yang.data.api.SimpleNode;
import org.opendaylight.yangtools.yang.data.impl.NodeUtils;
import org.opendaylight.yangtools.yang.data.impl.XmlTreeBuilder;
import org.opendaylight.yangtools.yang.data.impl.codec.xml.XmlDocumentUtils;
import org.opendaylight.yangtools.yang.model.api.SchemaContext;
import org.opendaylight.yangtools.yang.model.api.DataSchemaNode;
import org.opendaylight.controller.netconf.util.xml.XmlUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.w3c.dom.Document;
import org.xml.sax.InputSource;
import javax.xml.stream.XMLStreamException;
import javax.xml.transform.OutputKeys;
import javax.xml.transform.Transformer;
import javax.xml.transform.TransformerException;
import javax.xml.transform.TransformerFactory;
import javax.xml.transform.dom.DOMSource;
import javax.xml.transform.stream.StreamResult;
import java.io.ByteArrayInputStream;
import java.io.StringWriter;
import org.xml.sax.SAXException;
import java.io.StringReader;
import com.google.common.base.Optional;
public class XmlUtils {

private static final Logger _logger = LoggerFactory.getLogger(XmlUtils.class);

public static String compositeNodeToXml(CompositeNode cNode, SchemaContext schemaContext){
if (cNode == null) return new String();

//Document domTree = NodeUtils.buildShadowDomTree(cNode);
Document domTree = null;
try

catch (UnsupportedDataTypeException e)

StringWriter writer = new StringWriter();
try

catch (TransformerException e)

_logger.debug("compositeNodeToXml " + writer.toString());

return writer.toString();

}

public static CompositeNode xmlToCompositeNode(String xml, SchemaContext schemaContext){
if (xml==null || xml.length()==0) return null;

Node<?> dataTree = null;
try

catch (SAXException e)

_logger.debug("xmlToCompositeNode " + dataTree.toString());
return (CompositeNode) dataTree;
}
}

Thanks,
Vaishali

Using SchemaContext only payload is assumed to be data tree, not RPC one.

You may want to search SchemaContext for definition of that RPC
and then getInput/getOutput from Rpc Definition and pass that as an
argument to xml serialization/deserialization - so the XmlDocumentUtils
knows that your data needs to comform to that specific RPC definition
not global data tree definition.

Offending component was removed.

Reopening the defect. I am trying to use it in RPC clustering.

Tony,

The comments you mentioned, i tried to use them like following

public static String inputCompositeNodeToXml(CompositeNode cNode, SchemaContext schemaContext){
if (cNode == null) return new String();

//Document domTree = NodeUtils.buildShadowDomTree(cNode);
Document domTree = null;
try {
Set<RpcDefinition> rpcs = schemaContext.getOperations();
for(RpcDefinition rpc : rpcs) {
if(rpc.getQName().equals(cNode.getNodeType()))

}

} catch (UnsupportedDataTypeException e)

return domTransformer(domTree);
}

public static CompositeNode inputXmlToCompositeNode(QName rpc, String xml, SchemaContext schemaContext){
if (xml==null || xml.length()==0) return null;

Node<?> dataTree = null;
try {

Document doc = XmlUtil.readXmlToDocument(xml);
LOG.debug("xmlToCompositeNode Document is " + xml );
Set<RpcDefinition> rpcs = schemaContext.getOperations();
for(RpcDefinition rpcDef : rpcs) {
if(rpcDef.getQName().equals(rpc))

}
} catch (SAXException e)

LOG.debug("xmlToCompositeNode " + dataTree.toString());
return (CompositeNode) dataTree;
}

It works fine while node to xml conversation and give me output, something like this

<add-flow xmlns="urn:opendaylight:flow:service"><input><flow-name>Foo</flow-name><flow-ref>(urn:opendaylight:inventory?revision=2013-08-19)nodes/(urn:opendaylight:inventory?revision=2013-08-19)node[

]/(urn:opendaylight:flow:inventory?revision=2013-08-19)table[

]/(urn:opendaylight:flow:inventory?revision=2013-08-19)flow[

]</flow-ref><flow-table>(urn:opendaylight:inventory?revision=2013-08-19)nodes/(urn:opendaylight:inventory?revision=2013-08-19)node[

]/(urn:opendaylight:flow:inventory?revision=2013-08-19)table[

]</flow-table><instructions><instruction><apply-actions><action><dec-nw-ttl/><order>0</order></action></apply-actions><order>0</order></instruction></instructions><match><ethernet-match><ethernet-type><type>2048</type></ethernet-type></ethernet-match><ipv4-destination>10.0.0.2/24</ipv4-destination></match><node>(urn:opendaylight:inventory?revision=2013-08-19)nodes/(urn:opendaylight:inventory?revision=2013-08-19)node[

]</node><priority>2</priority><table_id>3</table_id><transaction-uri>DOM-1</transaction-uri></input></add-flow>

But it still throws illegalArgument Exception when converting xml to DomNode on the second node.

Hi,

I have added a test to transform the input for an RPC using XmlDocumentUtils (I also tried the xml you provided):

https://git.opendaylight.org/gerrit/#/c/9380/

It worked fine so could you please provide the exact data you are transforming ? And could you also provide your code (as a gerrit draft or give me a pointer) that I can reproduce and debug the issue ?

Actually, CompositeNode to XML transformation works fine for me also, its the other way around, which does not work fine. When i try to convert XML to composite node, it does create the Node, but the values inside instance identifier are not converted based on type, they are always String.

Say in Add flow RPC, i have table id in flow-ref instanceidentifier, which should get converted to Short type, but it always gives me String

I see.

I have fixed the issue in the commit I posted (there is also a test to prove it):

https://git.opendaylight.org/gerrit/#/c/9380/

Could you please verify ? Setting state to: waiting for review

There was a problem when using derived type of instance identifier, but it is fixed now.

Thanks for your fix, this works now for normal use case.

there was one special case for which it won't work, I have a fix for that, i'll try to put patch for same.