[CONTROLLER-1855] Controller should not error log any OptimisticLockFailedException which applications actually handle Created: 31/Jul/18  Updated: 28/Aug/18  Resolved: 02/Aug/18

Status: Resolved
Project: controller
Component/s: None
Affects Version/s: Oxygen SR2
Fix Version/s: Fluorine, Oxygen SR2

Type: Bug Priority: Medium
Reporter: Michael Vorburger Assignee: Tom Pantelis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks GENIUS-196 Optimistic lock failed for path /(urn... Open
blocks SRVUTILS-3 Failed to prepare transaction member-... To Do
Relates
relates to CONTROLLER-1802 Reduce ConcurrentDOMDataBroker TX fai... Resolved
relates to NETVIRT-1324 OptimisticLockFailedException.../flow... Resolved

 Description   

GENIUS-196 and SRVUTILS-3 seem to show that Controller error logs any OptimisticLockFailedException.

I'm pretty sure a while we had discussion about this concluding that this is bad - the logging is up to applications - they need to handle the returned Future. (Can't find respective old discussion / JIRA / Gerrit right now; anyone better at finding what I mean?)

Let's change this again?



 Comments   
Comment by Michael Vorburger [ 31/Jul/18 ]

CONTROLLER-1802 is the first issue ... see also https://git.opendaylight.org/gerrit/#/q/CONTROLLER-1802.

Do we just need to cherry-pick something from master to oxygen? Or change something we forget in CONTROLLER-1802 on master from an ERROR to a WARN or an INFO ?

Comment by Tom Pantelis [ 31/Jul/18 ]

master patch: https://git.opendaylight.org/gerrit/#/c/74701/

Comment by Michael Vorburger [ 02/Aug/18 ]

Oxygen https://git.opendaylight.org/gerrit/#/c/74706/ which JUST still made it for SR2.

These change the ERROR to a WARN.

Closing this issue.

Comment by Michael Vorburger [ 28/Aug/18 ]

FTR: This came up againĀ under NETVIRT-1324.

Generated at Wed Feb 07 19:56:37 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.