[CONTROLLER-2089] Do not store writerUuid in sal-akka-segmented-journal Created: 31/Dec/23  Updated: 01/Feb/24

Status: In Progress
Project: controller
Component/s: clustering
Affects Version/s: None
Fix Version/s: 7.0.12, 8.0.5, 9.0.1

Type: Improvement Priority: Medium
Reporter: Robert Varga Assignee: Samuel Schneider
Resolution: Unresolved Votes: 0
Labels: pick-next, pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks CONTROLLER-2043 Circuit breaker timeout with BGP and ... Confirmed
Issue split
split from CONTROLLER-2044 Improve sal-akka-raft serialization p... Confirmed

 Description   

As noted in CONTROLLER-2044 and CONTROLLER-2043, we have repeating writerUuid in the journal.

Perusing akka.persistence, this value is used only for sanity checking in a filter – and that filter will happily live with just empty strings.

On the write side, write a null String instead of writerUuid.
On the read side, read the uuid, bump always report empty string.

This should be a completely ABI compatible change.



 Comments   
Comment by Robert Varga [ 31/Dec/23 ]

Yeah, except if we do that we do not pass the TCK.
Looking at Cassandra, we need to store the writerUuid.

So now we need another bit of state ... essentially we need to record the position at which the writerUuid changes. Then we need to remap them during adaptation.

Generated at Wed Feb 07 19:57:10 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.