[CONTROLLER-221] Please clean up poms of md-sal Created: 20/Mar/14  Updated: 25/Jul/23  Resolved: 11/Sep/14

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Tomas Olvecky Assignee: Surekha Bejgam
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 555

 Description   

Especially use plugin management instead of defining code generators separately.



 Comments   
Comment by Moiz Raja [ 31/Mar/14 ]

Tomas,

Could you please add a little more detail to this.

Here is what I am looking for.

a. What is wrong?
b. Where is it wrong? A list of projects where the pom needs to be cleaned up would be useful.
c. What is the right thing to do? Use plugin management maybe. If you have examples of how to do it right that would be great.

Comment by Tomas Olvecky [ 01/Apr/14 ]

Moiz,
There are dependencies with versions that override parent pom's dependencyManagement.
e.g.
echo -e 'setns a=http://maven.apache.org/POM/4.0.0\nxpath //a:dependency[descendant::a:version]/a:artifactId/text()' | xmllint --shell ./topology-lldp-discovery/pom.xml
/ > setns a=http://maven.apache.org/POM/4.0.0
/ > xpath //a:dependency[descendant::a:version]/a:artifactId/text()
Object is a Node Set :
Set contains 1 nodes:
1 TEXT
content=commons-lang

I also saw guava and other lib versions hardcoded. Actually the pom above is even more broken - it should use org.apache.commons:commons-lang3 as defined in commons.

Regarding plugins, yang-maven-plugin is configured on multiple places. It should be moved do a parent pom, same way as it is in config subsystem.

Comment by Tony Tkacik [ 11/Sep/14 ]

Master have cleaned up pom files as of now.

Generated at Wed Feb 07 19:52:29 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.