Operating System: Linux
Platform: PC

(In reply to Dana Kutenicsova from comment #0)
> restconf/operational/bgp-rib:bgp-rib/rib/example-bgp-rib/loc-rib/tables/bgp-
> linkstate:linkstate-address-family/bgp-linkstate:linkstate-subsequent-
> address-family/linkstate-routes
>
> Returns correct xml, but if I want to descend to one concrete linkstate-route
>
> <linkstate-route><route-
> key>AAEAJwIAAAAAAAAAAQEAABoCAAAEAAAASAIBAAQoKCgoAgMABgAAAAAAQA==</route-
> key><identifier>1</identifier>
> ...
>
> restconf/operational/bgp-rib:bgp-rib/rib/example-bgp-rib/loc-rib/tables/bgp-
> linkstate:linkstate-address-family/bgp-linkstate:linkstate-subsequent-
> address-family/linkstate-routes/linkstate-route/
> AAEAJwIAAAAAAAAAAQEAABoCAAAEAAAASAIBAAQoKCgoAgMABgAAAAAAQA==
>
> I get: No data exists.

Hello Dana,

It will be really helpful to reproduce this bug, if you can tell us the steps you followed, while you came across this bug. The configurations which you have done for this bug.

I was able to reproduce the issue with this simple yang (added to the toaster):

container routes {
list route {
key "route-key";

leaf route-key

}
}

After putting an entry with route-key "AAEAJwIAAAAAAAAAAQEAABoCAAAEAAAASAIBAAQoKCgoAgMABgAAAAAAQA==", a subsequent GET to:
/config/toaster:routes/route/AAEAJwIAAAAAAAAAAQEAABoCAAAEAAAASAIBAAQoKCgoAgMABgAAAAAAQA==

didn't return any data.

The InstanceIdentifier lookup in the data store failed to return the node. I tracked the problem to the InstanceIdentifier.NodeIdentifierWithPredicates class hashCode/equals methods. It contains a key value Map and calls Map#hashCode and Map#equals. The problem is that the binary type is represented as a byte[] and Map performs shallow hashCode/equals so it would only work properly if the byte[] instances in the maps were the same. The same issue can occur with the NodeWithValue class.

I think an ideal solution would be to wrap the byte[] in a Binary class that would perform the deep hashCode/equals but the byte[] representation is entrenched in he code generation and other places. In lieu of that, the InstanceIdentifier classes need to perform deep hashCode/equals on the key values.

Submitted: https://git.opendaylight.org/gerrit/#/c/7519/

Verified against original problem.