[CONTROLLER-349] Stats Mgr to skip equality check on flow stats Created: 22/Apr/14  Updated: 25/Jul/23  Resolved: 04/May/15

Status: Resolved
Project: controller
Component/s: adsal
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Chi-Vien Ly Assignee: Chi-Vien Ly
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Mac OS
Platform: PC

External issue ID: 789

 Description   

Statistics Manager runs an equality check on the list of flow statistics
received from the protocol plugin with its cached ones to decide whether
to update or not, in order to avoid a cluster cache update.
In presence of flows on the switch, the flow updated statistics are always
different because of the milli and nano secs duration fields they contain

 Comments   
Comment by Debolina Bandyopadhyay [ 06/May/14 ]

Hello Chi-Vien,

What I understand from this bug is that, you don't want the mili and nano secs update in the flow to get written? You want to skip the time changes to get updated in statistics manager.

Comment by Alessandro Boch [ 06/May/14 ]

Hi Debolina,
this change is for skipping an equality check between two potentially long collection of objects which are assured to be always different.
The equality check is useless, an unnecessary processing.

Comment by Debolina Bandyopadhyay [ 07/May/14 ]

Is currently someone working on it?

Comment by Anil Vishnoi [ 12/May/14 ]

Just want to confirm, is this bug raised for MD-SAL based statistics manager module or AD-SAL based statistics manager module ? I looked at the AD-SAL based statistics manager code and seems like equal check is not there ( comment line says – // No equality check because duration fields change constantly). Can you please confirm.

Thanks
Anil

Comment by Vaclav Demcak [ 02/Oct/14 ]

Chi-Vien-Ly
Please could you check the new StatManager implementation and please describe your "BUG" better ... because the time (milli and nano) should be a marker for a point "how often the stat are updated"
And If it is still not expected behavior, please open new bug with better explanation.

Comment by Carol Sanders [ 04/May/15 ]

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL

Generated at Wed Feb 07 19:52:48 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.