NeutronPortsNorthbound.jpg
[CONTROLLER-438] issue in validations for nuetronPort creation Created: 01/May/14 Updated: 25/Jul/23 Resolved: 05/May/15 |
|
| Status: | Resolved |
| Project: | controller |
| Component/s: | adsal |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Ankit agarwal | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: Linux |
||
| Attachments: |
NeutronPortsNorthbound.jpg
|
| External issue ID: | 934 |
| Description |
|
In NeutronPortsNorthbound.java validation for subnet and ipAddress format are done after the call of canCreatePort() method whereas all these validations should be done beforehand. similar standards are followed in NeutronSubnetsNorthbound and NeutronNetworksNorthbound. |
| Comments |
| Comment by Ankit agarwal [ 01/May/14 ] |
|
Attachment NeutronPortsNorthbound.jpg has been added with description: highlighted area shows mentioned code blocks |
| Comment by Ankit agarwal [ 02/May/14 ] |
|
The same case is with UpdatePort as well. Here also the validations should be done before making the call for canUpdatePort() method. |
| Comment by Ankit agarwal [ 02/May/14 ] |
|
https://git.opendaylight.org/gerrit/6648 Patch submitted for the same. |
| Comment by Ankit agarwal [ 20/May/14 ] |
|
New patch (https://git.opendaylight.org/gerrit/7234) submitted. |
| Comment by Ankit agarwal [ 20/May/14 ] |
|
New patch (https://git.opendaylight.org/gerrit/7235) submitted. Earlier patches can be abandoned/ignored. |
| Comment by Ankit agarwal [ 20/May/14 ] |
|
Sorry for earlier multiple patches. patch (https://git.opendaylight.org/gerrit/#/c/7234/) |
| Comment by Carol Sanders [ 05/May/15 ] |
|
This bug is part of the project to Move all ADSAL associated component bugs to ADSAL. |