[CONTROLLER-457] OSGi errors after starting controller and mininet of10 simulation: ERROR o.o.c.sal.binding.impl.NotifyTask - Unhandled exception thrown by listener: org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter$$Broker$ListenerInvoker@51f1a91e Created: 07/May/14 Updated: 19/May/16 Resolved: 19/May/16 |
|
| Status: | Resolved |
| Project: | controller |
| Component/s: | adsal |
| Affects Version/s: | Helium |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Madhusudhan Ananderi | Assignee: | Giovanni Meo |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: Windows |
||
| External issue ID: | 965 |
| Description |
|
After starting the controller and mininet of10 simulation, I get this error: 1. Link to latest controller: https://jenkins.opendaylight.org/integration/job/integration-project-centralized-integration/lastSuccessfulBuild/artifact/distributions/base/target/distributions-base-0.1.2-SNAPSHOT-osgipackage.zip 2014-05-06 17:41:57.190 PDT [md-sal-binding-notification-1384] ERROR o.o.c.sal.binding.impl.NotifyTask - Unhandled exception thrown by listener: org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter$$Broker$ListenerInvoker@51f1a91e 2014-05-06 17:41:57.366 PDT [pool-15-thread-1] ERROR o.o.c.m.s.b.i.ForwardedBackwardsCompatibleDataBroker - Tx: DOM-2570 Rollback - Datastore commit failed. In the topology GUI, I see the following for the first time: Node ID - Ports If I try to attempt again, everything works fine, even I could not see any OSGi errors as well. Thanks, |
| Comments |
| Comment by Tony Tkacik [ 10/Jun/14 ] |
|
After small analysis it seems SwitchManager implementation is not thread-safe, org.opendaylight.controller.switchmanager.internal.SwitchManager.addNode() nodePropsCurr (retieved from nodeProps field) are null when method start executing nodeProps.putIfAbsent(node,nodeProps) returns non-null (other thread updated nodeProps for particular key), |
| Comment by Tony Tkacik [ 14/Jul/14 ] |
|
Implementation of addNode is not thread-safe, it captures stated of shared concurrent map at begining of addNode and then assumes same state for that |
| Comment by Carol Sanders [ 04/May/15 ] |
|
This bug is part of the project to Move all ADSAL associated component bugs to ADSAL |
| Comment by Robert Varga [ 19/May/16 ] |
|
AD-SAL has been removed, this issue will not be fixed. |