[CONTROLLER-561] DataCommitHandler Created: 19/Jun/14  Updated: 25/Jul/23  Due: 04/Jul/14  Resolved: 25/Jun/14

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Robert Gallas Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Windows
Platform: PC


External issue ID: 1209

 Description   

After registering DataCommitHandler TX is data change requestCommit() of DataCommitHandler is called even if no data was pushed into regisered part of tree.

2014-06-19 13:14:25.446 CEST [md-sal-binding-commit-0] INFO o.o.c.i.d.a.i.h.ServiceXXXXCommitHandler - ServiceXXXXCommitHandler - requesting commit for data modification id=DOM-4
2014-06-19 13:14:25.449 CEST [pool-15-thread-1] INFO o.o.c.i.d.a.i.h.ServiceXXXXCommitHandler -

FINISH COMMIT org.opendaylight.controller.md.sal.binding.impl.ForwardedBackwardsCompatibleDataBroker$ForwardedBackwardsCompatibleTransacion@413000f2

[ === PROPRIETARY LOG === ]

2014-06-19 13:14:25.458 CEST [pool-15-thread-1] ERROR o.o.c.m.s.b.i.ForwardedBackwardsCompatibleDataBroker - Transaction DOM-4 failed to complete
java.lang.NullPointerException: null
at org.opendaylight.controller.XXXX.device.app.impl.engine.domain.XXXX.getXXXXKey(XXXX.java:55) ~[na:na]
at org.opendaylight.controller.XXXX.device.app.impl.engine.domain.XXXX.<init>(XXXX.java:37) ~[na:na]
at org.opendaylight.controller.XXXX.device.app.impl.engine.EngineApi.requestXXXX(EngineApi.java:32) ~[na:na]
at org.opendaylight.controller.XXXX.device.app.impl.handlers.ServiceXXXXCommitHandler$Tx.finish(ServiceXXXXCommitHandler.java:72) ~[na:na]
at org.opendaylight.controller.md.sal.binding.impl.ForwardedBackwardsCompatibleDataBroker$3.apply(ForwardedBackwardsCompatibleDataBroker.java:182) ~[na:na]
at org.opendaylight.controller.md.sal.binding.impl.ForwardedBackwardsCompatibleDataBroker$3.apply(ForwardedBackwardsCompatibleDataBroker.java:177) ~[na:na]
at com.google.common.util.concurrent.Futures$1.apply(Futures.java:720) ~[na:na]
at com.google.common.util.concurrent.Futures$ChainingListenableFuture.run(Futures.java:859) ~[na:na]
at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:293) ~[na:na]
at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:150) ~[na:na]
at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:135) ~[na:na]
at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185) ~[na:na]
at com.google.common.util.concurrent.Futures$ChainingListenableFuture$1.run(Futures.java:873) ~[na:na]
at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:293) ~[na:na]
at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:150) ~[na:na]
at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:135) ~[na:na]
at com.google.common.util.concurrent.ListenableFutureTask.done(ListenableFutureTask.java:91) ~[na:na]
at java.util.concurrent.FutureTask$Sync.innerSet(FutureTask.java:281) ~[na:1.7.0_25]
at java.util.concurrent.FutureTask.set(FutureTask.java:141) ~[na:1.7.0_25]
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:339) ~[na:1.7.0_25]
at java.util.concurrent.FutureTask.run(FutureTask.java:166) ~[na:1.7.0_25]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~[na:1.7.0_25]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ~[na:1.7.0_25]



 Comments   
Comment by Tony Tkacik [ 25/Jun/14 ]

Offending API is going to be deprecated and replaced by AsyncDataBroker, BidningDataBroker and DOMDataBroker, which are documented in https://git.opendaylight.org/gerrit/#/c/8046/

Decreased severity to minor, since these APIs are going to be replaced.

Comment by Robert Gallas [ 25/Jun/14 ]

Accepted.

Generated at Wed Feb 07 19:53:20 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.