[CONTROLLER-583] Problems with AbstractProviderModule Auto-generated Code Created: 26/Jun/14 Updated: 25/Jul/23 Resolved: 08/Jul/14 |
|
| Status: | Resolved |
| Project: | controller |
| Component/s: | config |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Reinaldo Penno | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: Mac OS |
||
| Issue Links: |
|
||||||||
| External issue ID: | 1246 | ||||||||
| Description |
|
looked closely at the Abstract<projectname>ProviderModule auto-generated code and noticed a couple of small things. if (dataBroker!=null) { dataBrokerDependency = dependencyResolver.resolveInstance(org.opendaylight.controller.sal.binding.api.data.DataProviderService.class, dataBroker, dataBrokerJmxAttribute);; <=== double semi-colon }if(oldInstance!=null && canReuseInstance(oldModule)) { <=== Is this a missing else or just an indentation problem ? instance = reuseInstance(oldInstance); }else { And there is an unnecessary semi-colon here ;this.oldModule=null; Maybe the auto-generated files should go through appropriate tooling to detect these things. |