[CONTROLLER-601] Flow conversion bugs in sal-compatibility Created: 04/Jul/14  Updated: 19/Oct/17  Resolved: 07/Jul/14

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: Helium
Fix Version/s: None

Type: Bug
Reporter: Shigeru Yasuda Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC


External issue ID: 1306

 Description   

I found 2 bugs in flow conversion routine in sal-compatibility.

1. A NullPointerException is always thrown when a flow entry that contains
IN_PORT match field value is installed via sal-compatibility.
sal-compatibility sets a string representation of AD-SAL NodeConnector ID
(e.g. "OF|2") to in-port in a flow entry. But it must be converted into
MD-SAL NodeConnectorId (e.g. "openflow:1:2").

2. An invalid MD-SAL match is created if zero is set in DL_VLAN match field.
If zero is set in DL_VLAN match field in a flow entry, it must match packets
without VLAN tag. Thus in that case false must be set to vlan-id-present field
in a MD-SAL flow entry.



 Comments   
Comment by Shigeru Yasuda [ 04/Jul/14 ]

I pushed a patch.

https://git.opendaylight.org/gerrit/8664

Comment by Shigeru Yasuda [ 07/Jul/14 ]

Merged.

Generated at Wed Feb 07 19:53:26 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.