[CONTROLLER-684] Minimum values of SET_TP_SRC and SET_TP_DST are incorrectly set to 1. Created: 13/Aug/14  Updated: 05/May/15  Resolved: 05/May/15

Status: Resolved
Project: controller
Component/s: adsal
Affects Version/s: Helium
Fix Version/s: None

Type: Bug
Reporter: Hideyuki Tai Assignee: Hideyuki Tai
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 1536

 Description   

Minimum values of SET_TP_SRC and SET_TP_DST actions are incorrectly set to 1 in SAL (Service Abstraction Layer).

Therefore, when I tried to install a flow entry which contains an action "SET_TP_SRC=0", the following error message was output.

ERROR o.o.controller.sal.action.Action - Invalid field value assignement. For type: setTpSrc Expected: [0x1-0xffff], Got: 0x0

Because the range of TCP port and UDP port includes 0, the minimum values of SET_TP_SRC and SET_TP_DST actions must be set to 0.

What I used to reproduce the issue
----------------------------------

The latest version of the Base Edition on August 12th, 2014.
I built the Base Edition from source code of the Git repository of Integration group.

$ git log -3 --oneline
759ec09 Updating VTN OF13 to get mininet to start with OpenFlow13
418c937 Patch to fix VTN after OVSDB changed Neutron artifact name
7b21316 BUG-1255 extension proposal

How to reproduce the issue
--------------------------

1. Start up the Base Edition.

$ ./run.sh

2. Install a flow entry by using REST API of FlowProgrammer.

For example, you can use the REST API by executing curl command on Linux as follows.

$ curl --user "admin":"admin" -H "Content-type: application/json" -X PUT \
http://localhost:8080/controller/nb/v2/flowprogrammer/default/node/OF/00:00:00:00:00:00:00:01/staticFlow/flow0 \
-d '{ "installInHw":"true", "name":"flow0", "node":

{"id":"00:00:00:00:00:00:00:01","type":"OF"}

,"ingressPort":"2","priority":"501","etherType":"0x800","protocol":"tcp","actions":["SET_TP_SRC=0"] }'

You can see the following error message in the OSGi console right after you execute the above command.

ERROR o.o.controller.sal.action.Action - Invalid field value assignement. For type: setTpSrc Expected: [0x1-0xffff], Got: 0x0



 Comments   
Comment by Hideyuki Tai [ 13/Aug/14 ]

I've verified that this issue is fixed by the following patch.
https://git.opendaylight.org/gerrit/#/c/9904/

Comment by Carol Sanders [ 05/May/15 ]

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL.

Generated at Wed Feb 07 19:53:37 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.