[CONTROLLER-690] ConfigPusherImpl.java - Unnecessary Synchronization Created: 14/Aug/14 Updated: 19/Oct/17 Resolved: 05/Jul/17 |
|
| Status: | Resolved |
| Project: | controller |
| Component/s: | config |
| Affects Version/s: | Helium |
| Fix Version/s: | None |
| Type: | Improvement | ||
| Reporter: | Devin Avery | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: Mac OS |
||
| Issue Links: |
|
||||||||
| Description |
|
The opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusherImpl.java performs method level synchronization on a couple of methods which could possibly end up waiting for a long period of time. In general you do NOT want to perform synchronization of blocks of code which could possibly take a long time to run as it will just back everything up. See Gerrit 9844 for some inline comments. This bug should be used to asses if synchronization is really necessary on the methods provided, and if it it then it should be optimized. |
| Comments |
| Comment by Maros Marsalek [ 02/Jun/15 ] |
|
Needs to be verified if still present and necessary. |
| Comment by Tom Pantelis [ 05/Jul/17 ] |
|
The CSS is being deprecated so not worth addressing. |