[CONTROLLER-760] IllegalStateException thrown by FlowCapableTopologyExporter Created: 03/Sep/14  Updated: 25/Jul/23  Resolved: 16/Sep/14

Status: Resolved
Project: controller
Component/s: mdsal
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Moiz Raja Assignee: Tom Pantelis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Mac OS
Platform: PC

Issue Links:
Duplicate
is duplicated by CONTROLLER-706 Clustering : IllegalStateException - ... Resolved
External issue ID: 1688

 Description   

Note that this stacktrace is from a distribution which uses clustering. However this appears to be a bug in the FlowCapableTopologyExporter which tries to access a transaction in a callback which gets executed asynchronously and could very likely get executed after the transaction is submitted on the OperationProcessor thread.

2014-09-03 12:20:55,118 | ERROR | lt-dispatcher-18 | ExecutionList | 52 - com.google.guava - 14.0.1 | RuntimeException while executing runnable com.google.common.util.concurrent.Futures$4@6dfa3d3c with executor com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService@47ca668c
java.lang.IllegalStateException: Transaction was already submited.
at com.google.common.base.Preconditions.checkState(Preconditions.java:149)[52:com.google.guava:14.0.1]
at org.opendaylight.controller.md.sal.dom.broker.impl.DOMForwardedWriteTransaction.checkNotCommited(DOMForwardedWriteTransaction.java:157)[128:org.opendaylight.controller.sal-broker-impl:1.1.0.SNAPSHOT]
at org.opendaylight.controller.md.sal.dom.broker.impl.DOMForwardedWriteTransaction.checkNotReady(DOMForwardedWriteTransaction.java:148)[128:org.opendaylight.controller.sal-broker-impl:1.1.0.SNAPSHOT]
at org.opendaylight.controller.md.sal.dom.broker.impl.DOMForwardedWriteTransaction.delete(DOMForwardedWriteTransaction.java:96)[128:org.opendaylight.controller.sal-broker-impl:1.1.0.SNAPSHOT]
at org.opendaylight.controller.md.sal.dom.broker.impl.DOMForwardedWriteTransaction.delete(DOMForwardedWriteTransaction.java:53)[128:org.opendaylight.controller.sal-broker-impl:1.1.0.SNAPSHOT]
at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.doDelete(AbstractWriteTransaction.java:144)[131:org.opendaylight.controller.sal-binding-broker-impl:1.1.0.SNAPSHOT]
at org.opendaylight.controller.md.sal.binding.impl.BindingDataWriteTransactionImpl.delete(BindingDataWriteTransactionImpl.java:73)[131:org.opendaylight.controller.sal-binding-broker-impl:1.1.0.SNAPSHOT]
at org.opendaylight.md.controller.topology.manager.FlowCapableTopologyExporter$10$1.onSuccess(FlowCapableTopologyExporter.java:232)[203:org.opendaylight.controller.md.topology-manager:1.1.0.SNAPSHOT]
at org.opendaylight.md.controller.topology.manager.FlowCapableTopologyExporter$10$1.onSuccess(FlowCapableTopologyExporter.java:224)[203:org.opendaylight.controller.md.topology-manager:1.1.0.SNAPSHOT]
at com.google.common.util.concurrent.Futures$4.run(Futures.java:1149)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:293)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:150)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:135)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.Futures$ChainingListenableFuture$1.run(Futures.java:873)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:293)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.Futures$ImmediateFuture.addListener(Futures.java:99)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.Futures$ChainingListenableFuture.run(Futures.java:866)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:293)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:150)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:135)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185)[52:com.google.guava:14.0.1]
at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[52:com.google.guava:14.0.1]
at org.opendaylight.controller.cluster.datastore.TransactionProxy$TransactionContextImpl$3.onComplete(TransactionProxy.java:624)[237:org.opendaylight.controller.sal-distributed-datastore:1.1.0.SNAPSHOT]
at akka.dispatch.OnComplete.internal(Future.scala:247)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.OnComplete.internal(Future.scala:244)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:174)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:171)[222:com.typesafe.akka.actor:2.3.4]
at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:32)[219:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.processBatch$1(BatchingExecutor.scala:67)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.apply$mcV$sp(BatchingExecutor.scala:82)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.apply(BatchingExecutor.scala:59)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.apply(BatchingExecutor.scala:59)[222:com.typesafe.akka.actor:2.3.4]
at scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:72)[219:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at akka.dispatch.BatchingExecutor$Batch.run(BatchingExecutor.scala:58)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:41)[222:com.typesafe.akka.actor:2.3.4]
at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:393)[222:com.typesafe.akka.actor:2.3.4]
at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)[219:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)[219:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)[219:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)[219:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]

 Comments   
Comment by Tom Pantelis [ 11/Sep/14 ]

We can either block on the reads waiting for completion or keep it async and enqueue the deletes on the OperationProcessor. I think the latter should be OK.

Comment by Tom Pantelis [ 16/Sep/14 ]

Submitted https://git.opendaylight.org/gerrit/#/c/11058/

Generated at Wed Feb 07 19:53:48 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.