[CONTROLLER-823] Invalid request reply match in netconf-connector Created: 12/Sep/14  Updated: 17/Sep/14  Resolved: 17/Sep/14

Status: Resolved
Project: controller
Component/s: netconf
Affects Version/s: Helium
Fix Version/s: None

Type: Bug
Reporter: Maros Marsalek Assignee: Maros Marsalek
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 1842

 Description   

Following exception appears in log:
2014-09-12 10:47:03.804 CEST [nettyThreadgroupModule$NioEventLoopGroupCloseable-5-1] WARN o.o.c.s.c.n.l.NetconfDeviceCommunicator - RemoteDevice

{XX}

: Invalid request-reply match, reply message contains different message-id...

And all next requests are failed.

It seems that this happens to pending write messages (AsyncSshHandler). If pending is unlocked, the pending message can be outrun by next message being sent. So a small race condition there.

Stress test in NetconfITSecureTest should have caught that, but a few issues there:
1. message-id is still the sam
2. SimpleNetconfSessionListener is in use that does not perform required check

 Comments   
Comment by Maros Marsalek [ 16/Sep/14 ]

https://git.opendaylight.org/gerrit/#/c/11228/

Actual problem was not the race condition, but not resetting the byte buffer after it was copied during first-attempt-write.

Generated at Wed Feb 07 19:53:58 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.