Exception details:
org.opendaylight.controller.sal.core.ConstructionException: Type of incoming object:class java.lang.String not compatible with expected type:class java.lang.Short or Node type incompatible:OF
"md-sal-binding-notification-199@13469" daemon prio=5 tid=0x2ff nid=NA runnable
java.lang.Thread.State: RUNNABLE
at org.opendaylight.controller.sal.compatibility.ToSalConversionsUtils.fromNodeConnectorRef(ToSalConversionsUtils.java:377)
at org.opendaylight.controller.sal.compatibility.ToSalConversionsUtils.actionFrom(ToSalConversionsUtils.java:212)
at org.opendaylight.controller.sal.compatibility.ToSalConversionsUtils.toFlow(ToSalConversionsUtils.java:142)
at org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter.toFlowOnNode(InventoryAndReadAdapter.java:702)
at org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter.onFlowsStatisticsUpdate(InventoryAndReadAdapter.java:625)
at org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter$$Broker$ListenerInvoker.onNotification(InventoryAndReadAdapter$$Broker$ListenerInvoker.java:-1)
at org.opendaylight.controller.sal.binding.impl.AbstractNotificationListenerRegistration.notify(AbstractNotificationListenerRegistration.java:38)
at org.opendaylight.controller.sal.binding.impl.NotifyTask.run(NotifyTask.java:42)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Info on where exception takes place:
https://www.dropbox.com/s/z0gmcws4ypt1pn1/Screenshot%202014-09-22%2013.21.26.png?dl=0
[14:06:23] <flaviof> hi edwarnicke. can you tell me who is a good person to talk about this piece of code: https://www.dropbox.com/s/prdhresrdcfcyv5/Screenshot%202014-09-22%2014.03.46.png?dl=0 ?
[14:06:52] <flaviof> edwarnicke: looking at CONTROLLER-879...
[14:07:08] <edwarnicke> flaviof: Which file?
[14:07:41] <flaviof> edwarnicke: /org/opendaylight/controller/sal/0.8.1-SNAPSHOT/sal-0.8.1-20140922.073911-1029.jar!/org/opendaylight/controller/sal/core/NodeConnector.class
[14:08:11] <edwarnicke> flaviof: Talk to Madhu
[14:08:29] <flaviof> edwarnicke: ha.. ez enough. 
ty!
I would like to assert that I apparently was delusional when I told flavio to talk to Madhu about this bug.
Not a Fix: https://git.opendaylight.org/gerrit/#/c/11497/
Makes the logging clearer on what just happened. From the logs below, it looks like someone wrote a flow with a NodeConnectorId of OF:107783256356163:NORMAL... since this doesn't match the format OFplugin uses, our converters are failing (and there's no way they couldn't).
It looks like someone is writing invalid flows... but I could be wrong.
I've hit this comment too and I've chased it into the same region of the code. I too though I was calling something incorrectly. I've spent several hours chasing this and I don't think I'm calling anything incorrectly. The Flow that I think was causing this on my side was created as:
(When I see this problem, the node ID is OF:<datapathID>:FLOOD
private static Instruction createInstructionApplyActionsFlood(final int order)
{ final OutputActionBuilder outputActionBuilder = new OutputActionBuilder(); final Uri uri = new Uri("FLOOD"); outputActionBuilder.setOutputNodeConnector(uri); // create an actonBuilder final ActionBuilder actionBuilder = new ActionBuilder(); actionBuilder.setAction(new OutputActionCaseBuilder().setOutputAction(outputActionBuilder.build()).build()); actionBuilder.setOrder(0); actionBuilder.setKey(new ActionKey(0)); // Create an Apply Action final ApplyActionsBuilder applyActionBuilder = new ApplyActionsBuilder(); applyActionBuilder.setAction(ImmutableList.of(actionBuilder.build())); // Wrap our Apply Action in an Instruction final InstructionBuilder instructionBuilder = new InstructionBuilder(); instructionBuilder.setInstruction(new ApplyActionsCaseBuilder().setApplyActions(applyActionBuilder.build()).build()); instructionBuilder.setOrder(order); instructionBuilder.setKey(new InstructionKey(order)); return instructionBuilder.build(); }NOTE: This code comes from one of the code samples that's out there.
Jim,
Somewhere someone is writing an FlowCapable Node with MD-SAL NodeID of 'OF:107783256356163:CONTROLLER' etc. Thats an AD-SAL NodeID, and not an MD-SAL NodeID and thus we have no idea how to translate it (and also no idea how to actually program it meaningfully on a switch).
You need to chase this down to where you are missetting the NodeConnectorID for the flow to resolve the issue.
I have drilled down to where the issue is located:
The function
org.opendaylight.controller.sal.compatibility.
NodeMapping.
toADNodeConnectorId(final NodeConnectorId nodeConnectorId, final NodeId nodeId)
Is attempting to detect the special cases and would return SPECIALNODECONNECTORID:
if (nodeConnectorId.equals(toLocalNodeConnectorId(nodeId)) ||
nodeConnectorId.equals(toNormalNodeConnectorId(nodeId)) ||
nodeConnectorId.equals(toControllerNodeConnectorId(nodeId)))
in this case – however – the toControllerNodeConnectorId(nodeId) and
nodeConnectorId are different in their NodeIDType section:
OF:1234:CONTROLLER
openflow:1234:CONTROLLER
Moiz: it looks like you are the one who added the logic to return SPECIALNODECONNECTORID. Can you advise what is the best way of fixing this?
I have a simple proposal, but I'm not sure if that is what you would do.
– flavio
Links that shows code involved with this issue:
https://www.dropbox.com/s/txpb9m5sm2wr7re/Screenshot%202014-11-06%2006.27.41.png?dl=0
https://www.dropbox.com/s/rtyukw4n5ies2tr/Screenshot%202014-11-06%2006.28.08.png?dl=0
https://www.dropbox.com/s/9n2bymnlpqx9vsn/Screenshot%202014-11-06%2006.29.17.png?dl=0
https://www.dropbox.com/s/hlz3whx7e8n8o1i/Screenshot%202014-11-06%2006.32.51.png?dl=0
https://www.dropbox.com/s/5o2ztlq373r6wtt/Screenshot%202014-11-06%2006.41.22.png?dl=0
From: Flavio Fernandes <ffernand@redhat.com>
Subject: update on the proposed changes...
Date: November 6, 2014 at 6:24:23 PM EST
To: "Ed Warnicke (eaw)" <eaw@cisco.com>
… it is a no go.
by making the changes you mentioned, the Uri became just ‘CONTROLLER’. W/out the 'OF:dpid:’ prefix:
https://www.dropbox.com/s/w5veevdft0hqow8/Screenshot%202014-11-06%2018.18.33.png?dl=0
[redhatlaptop:controller.git]$ git diff
diff --git a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibili
index dcc1a46..7713986 100644
— a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSa
+++ b/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSa
@@ -208,8 +208,8 @@ public class ToSalConversionsUtils {
Uri nodeConnector = ((OutputActionCase) sourceAction).getOutputAction().getOutputNodeConnector();
if (nodeConnector != null) {
//for (Uri uri : nodeConnectors)
}
} else if (sourceAction instanceof PopMplsActionCase) {
so I gotta believe that the ‘node.getType()":"+node.getID()”:”’ are very needed. Is this a case where a translator from ‘OF’ to ‘open flow’
is missing?
Do you see anything wrong with the gerrit I’m proposing: https://git.opendaylight.org/gerrit/#/c/12568/ ?
Martin has actually blessed it...
Please advice,
— flavio
From: Flavio Fernandes <ffernand@redhat.com>
Date: Sat, Nov 8, 2014 at 7:03 AM
Subject: Re: [ovsdb-dev] CONTROLLER-879 – Continuous WARN logs in o.o.c.s.c.ToSalConversionsUtils
To: Srini Seetharaman <srini.seetharaman@gmail.com>, "controller-dev@lists.opendaylight.org" <controller-dev@lists.opendaylight.org>
Cc: "Ed Warnicke (eaw)" <eaw@cisco.com>, "Martin Bobak -X (mbobak - Pantheon Technologies SRO at Cisco)" <mbobak@cisco.com>, "Mestery, Kyle" <kyle.mestery@hp.com>, "<ovsdb-dev@lists.opendaylight.org>" <ovsdb-dev@lists.opendaylight.org>, "openflowplugin-dev@lists.opendaylight.org" <dev@lists.opendaylight.org>, Colin Dixon <colin@colindixon.com>
On Fri, Nov 7, 2014 at 6:17 PM, Srini Seetharaman
<srini.seetharaman@gmail.com> wrote:
> Hi Ed
> I just created a sample project, and used the sal-compatibility and
> switchmanager. I noticed the errors popped up. I really don't have any
> complex logic except to implement IInventoryListener.
>
> I went through the code and feel this is where the error is coming from.
> Please let me know if this sounds right to you:
>
Thanks for this message Srini! Can you share more details on the
sample project you wrote?
I'm curious how this is something that only a few folks see. Contrary
to Ed's suspicion, I
strongly believe this is not related to ovsdb at all. Any code path that uses
org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter.onFlowsStatisticsUpdate(InventoryAndReadAdapter.java:710)
will suffer from this. That is so, because
org.opendaylight.controller.sal.compatibility.NodeMapping.toADNode()
uses NodeIDType.OPENFLOW, which
is hard coded as 'OF'.
According to InteliJ, there are 153 uses of 'NodeIDType.OPENFLOW'
(public static and not final?!?):
https://www.dropbox.com/s/gjpma2691c6sahm/Screenshot%202014-11-08%2007.00.21.png?dl=0
And this is only in the controller repository! I don't know the history of
how 'OF' became 'openflow' in ODL, but that change – together with
the very open ended nature of the
Uri object – makes me think this is not the last time issues like
this will occur.
So, yes... I think the changes you are proposing would address CONTROLLER-879.
I came up with a proposal that would address it too, but instead of
mapping OF to openflow
it simply trims it out:
https://git.opendaylight.org/gerrit/#/c/12568/
It is likely that Ed likes your changes better and I'm very okay
with that. It has been almost 2
months since we opened this issue and I'll be glad when its put to bed. 
Best,
– flavio
> diff --git
> a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSalConversionsUtils.java
> b/opendaylight/md-sal/compatibility/sal-
> index dcc1a46..4607058 100644
> —
> a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSalConversionsUtils.java
> +++
> b/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSalConversionsUtils.java
> @@ -208,7 +208,7 @@ public class ToSalConversionsUtils {
> Uri nodeConnector = ((OutputActionCase)
> sourceAction).getOutputAction().getOutputNodeConnector();
> if (nodeConnector != null) {
> //for (Uri uri : nodeConnectors)
> }
>
>
> On Mon, Nov 3, 2014 at 11:20 AM, Ed Warnicke (eaw) <eaw@cisco.com> wrote:
>>
>> This isn’t an OFplugin or MD-SAL or adaptor issue. Its an app issue.
>>
>>
>> Some app is writing a flow with an invalid NodeConnectorID on the MD-SAL
>> side of:
>>
>> OF:107783256356163:CONTROLLER
>>
>> We can’t translate that correctly from the MD-SAL side to the AD-SAL
>> side because its not an MD-SAL style NodeConnectorID.
>> I also don’t see how it can correctly get programmed on a switch either.
>>
>> This needs to be tracked down in the application code that is doing the
>> programming incorrectly to begin with.
>>
>> I suspect this is a bug in the ovsdb code that is failing to create a
>> correct NodeConnectorId, and thus that’s probably
>> where it should be fixed.
>>
>> Ed
>>
>> On Nov 3, 2014, at 9:20 AM, Colin Dixon <colin@colindixon.com> wrote:
>>
>> Adding a link to the bug:
>> https://bugs.opendaylight.org/show_bug.cgi?id=2021
>>
>> And cc'ing openflowplugin-dev.
>>
>> Cheers,
>> --Colin
>>
>>
>> On Mon, Nov 3, 2014 at 9:13 AM, Flavio Fernandes <ffernand@redhat.com>
>> wrote:
>>>
>>> Hello Martin,
>>>
>>> I was wondering if you have any updates on CONTROLLER-879. I don’t actually
>>> know why/how it got assigned to you.
>>>
>>> This bug is in Helium and it would be great if we could fix it, because
>>> it makes log very chatty when doing openstack
>>> integration.
>>>
>>> Thanks,
>>>
>>> — flavio
>>>
mail thread: https://lists.opendaylight.org/pipermail/ovsdb-dev/2014-November/000845.html
master:
https://git.opendaylight.org/gerrit/#/c/12568/
stable/helium (SR2):
https://git.opendaylight.org/gerrit/#/c/12828/