[CONTROLLER-946] Constant topology refresh in the DOM tree Created: 20/Oct/14  Updated: 19/Oct/17  Resolved: 05/May/15

Status: Resolved
Project: controller
Component/s: adsal
Affects Version/s: Helium
Fix Version/s: None

Type: Bug
Reporter: Leonid Bogdanov Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 2218

 Description   

The topology nodes in the tree are being constantly overwritten by the FlowCapableTopologyExporter. The latter listens to link discovery events and unconditionally puts information about a link into the tree, even when the link was already known, not newly discovered.
It doesn't seem right to update the topology data when there are no real changes, 'cause it may trigger data listeners with some side effects and any custom augmentations of the topology subtree will be lost.



 Comments   
Comment by Leonid Bogdanov [ 24/Oct/14 ]

Proposed patch https://git.opendaylight.org/gerrit/12235

Comment by Michal Rehak [ 30/Oct/14 ]

Hi Leonid,
I am afraid that transaction.merge will never delete links which went down during controller lifetime.

Could you check that scenario?

Thank you.

Comment by Leonid Bogdanov [ 30/Oct/14 ]

Hi Michal,

If I'm not mistaken there is a separate event for this which is handled by org.opendaylight.md.controller.topology.manager.FlowCapableTopologyExporter.onLinkRemoved(), so such links will be removed eventually.

Thank you.

Comment by Ed Warnicke [ 14/Nov/14 ]

Leonid,

Did you check the link removal case?

I overall like your point, and would like to merge your patch, but wanted to check on if you had checked the link removal case.

Comment by Leonid Bogdanov [ 14/Nov/14 ]

Hi Ed,

I checked the link removal case using Mininet - it worked as expected for me.

Comment by Carol Sanders [ 05/May/15 ]

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL.

Generated at Wed Feb 07 19:54:17 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.