[DLUX-20] Open-Topology.js - Contains code copied from internet - unknown license Created: 21/Jan/15  Updated: 15/Jun/15  Resolved: 15/Jun/15

Status: Resolved
Project: dlux
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Devin Avery Assignee: Maxime Millette-Coulombe
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 2617

 Description   

We found when scanning our code that the following file:

modules/loader-resources/src/main/resources/assets/js/open-topology.js contains source code that was actually copied from a website which does not have a clear license file.

As such we do not believe the ODL has the rights to ship this file.

=================
File open-topology.js contains forensic similarities (lines 1192-1205) contains forensic similarities to code for spacetree orientation. It is unclear the true origin of the code.
Similar code can be found at
http://stackoverflow.com/questions/23596753/how-do-i-change-default-orientation-in-infovis-spacetree
http://stackoverflow.com/questions/13846378/javascript-variable-scope-hindering-me
https://groups.google.com/forum/#!searchin/javascript-information-visualization-toolkit/top/javascript-information-visualization-toolkit/MhXSXJUmaIk/V5JNwSe359gJ

====================

We need to make sure that we have the rights to use this content in DLUX, or remove it if we don't.

 Comments   
Comment by Devin Avery [ 21/Jan/15 ]

Phil Robb identified the license on the code - seems to be BSD.

We need to make sure we attribute the code to this author in compliance with the BSD license.

==============
For the code in question, it looks like this originally comes from the Spacetree.js project located here:
http://philogb.github.io/blog/assets/jit-1.0a/doc/core/files/Spacetree-js.html

This project is licensed under BSD, so our use of the code is not a problem, but doing so without giving Copyright attribution is out of compliance with the license.

Let me know if you agree this seems to be the source for this code. In particular, from the Examples/Spacetree/example2.js file, within this '.zip': http://philogb.github.io/jit/downloads/Jit-2.0.1.zip
==============

Comment by Harman Singh [ 22/Apr/15 ]

Maxime, Do we still use this file?, if not, we can just remove it

Comment by Maxime Millette-Coulombe [ 22/Apr/15 ]

(In reply to Harman Singh from comment #2)
> Maxime, Do we still use this file?, if not, we can just remove it

I don't remember having use this file. Maybe an orphaned file from the move to modulation. I see an old url that we don't use since a while (before opendaylight karaf) so i think we can remove this file.

Comment by Harman Singh [ 15/Jun/15 ]

https://git.opendaylight.org/gerrit/#/c/20746/

Generated at Wed Feb 07 19:57:43 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.