[GBP-175] SfcNshHeader builder doesn't include default value for UDP port Created: 13/Jul/15 Updated: 19/Oct/17 |
|
| Status: | Confirmed |
| Project: | groupbasedpolicy |
| Component/s: | Renderer:OfOverlay |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Thomas Bachman | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 3984 |
| Priority: | Normal |
| Description |
|
The SfcNshHeader class has a builder, as well as an "isValid()" method. The current isValid() method doesn't check for UDP port. This would be okay if there was a default port number provided, but there isn't a default method provided. We should include the UDP port in the isValid() method, and either include a default value for the UDP port or require it to be set explicitly in order for isValid() to return true. |
| Comments |
| Comment by Thomas Bachman [ 23/Jul/15 ] |
|
This gerrit contains a test for the "isValid()" method. We should also update the unit test when we fix the bug. |
| Comment by Dhevendran Kulandaivel [ 25/May/16 ] |
|
Hi I am working on this. Thanks & Regards, |
| Comment by Dhevendran Kulandaivel [ 26/May/16 ] |
|
Hi Thomas Bachman I have pushed this for rview : https://git.opendaylight.org/gerrit/#/c/39457/ Thanks & Regards, |
| Comment by Dhevendran Kulandaivel [ 01/Jun/16 ] |
|
As Martin Sunal comment on the review link https://git.opendaylight.org/gerrit/#/c/39457/, I discored this check-in. The patch will be available from Martin Sunal |