[GBP-191] OrdinalFactory throws Exception Created: 02/Sep/15 Updated: 06/Jul/16 Resolved: 06/Jul/16 |
|
| Status: | Resolved |
| Project: | groupbasedpolicy |
| Component/s: | Renderer:OfOverlay |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Konstantin Blagov | Assignee: | Keith Burns |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 4232 |
| Priority: | Normal |
| Description |
|
Methods in lass OrdinalFactory throw Exception (i.e. generic highest-level unspecified Throwable). This can be changed to more specific exception object. The only usage for these Exceptions I could find after brief investigation is in PolicyManager#call, where it checks in a most generic way whether table.update succeeded. At least we could separate RuntimeException from exceptions thrown because of inner logic failure: bad IDs in arguments, inconsistency in datastore etc... |
| Comments |
| Comment by Keith Burns [ 11/Oct/15 ] |
|
Will address this when performing reverse mapping for Instrumentation. |
| Comment by Tomas Cechvala [ 06/Jul/16 ] |
|
Discussed with Kosto, no need for fixing this since code has changed significantly and number of potential exceptions has reduced. |