[GBP-58] Incorrect tunnel selection at OVS switch. Created: 25/May/15  Updated: 15/Jun/15  Due: 12/Jun/15  Resolved: 15/Jun/15

Status: Resolved
Project: groupbasedpolicy
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Tomas Cechvala Assignee: Thomas Bachman
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Blocks
blocks GBP-36 SFC Improvements for distributed clas... Resolved
External issue ID: 3366
Priority: Highest

 Description   

There are two vxlan tunnels which need to be created - one for ordinary traffic, other for SFC traffic. These two tunnels are of different types. Only one tunnel of it's type should be stored in HashMap located in SwitchManager. The same key though is used for both of these tunnel, so only one gets inserted. There is also a condition which allows tunnel to be put into that hashmap only if the map is empty. This causes ordinary traffic to be routed into a wrong tunnel.

 Comments   
Comment by Tomas Cechvala [ 26/May/15 ]

SFC tunnel is not of type TunnelTypeVxlanGpe.

Comment by Keith Burns [ 04/Jun/15 ]

(In reply to Tomas Cechvala from comment #1)
> SFC tunnel is not of type TunnelTypeVxlanGpe.

This needs to be changed.

1. SwitchManager should maintain state. That means all tunnels and types configured.
ChainAction uses this:
NodeConnectorId tunOpenFlowPort = SwitchManager.getTunnelPort(netElements.getNodeId(), TunnelTypeVxlanGpe.class);

And I feel this is valid.

2. of-overlay.yang already describes an encapsulation type (container of-overlay-config).

I propose that we are able to set the default encapsulation type via the datastore, and have a method to query it. This can be locked into vxlan for now, but we should be able to .getDefaultEncapsulation() if there is more than one choice, and if something needs a specific one (like chaining) it should be able to query it.

Let me have a crack at a patch to explain what I mean.

Comment by Keith Burns [ 15/Jun/15 ]

https://git.opendaylight.org/gerrit/#/c/22539/

Generated at Wed Feb 07 20:01:01 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.