[GENIUS-140] AlivenessMonitor is broken Created: 25/May/18  Updated: 28/May/18  Resolved: 28/May/18

Status: Resolved
Project: genius
Component/s: None
Affects Version/s: None
Fix Version/s: Oxygen-SR2, Fluorine

Type: Bug Priority: Medium
Reporter: Michael Vorburger Assignee: Michael Vorburger
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

cloudy on genius-dev (and follow-ups) found that AlivenessMonitor is currently broken - and likely has been for a while.

He points out that the change 64984 made in AlivenessMonitor by tpantelis likely to clean up generics warnings replaced an alivenessProtocolHandlerRegistry.getOpt(objPayload.getClass()) by .getOpt(Packet.class) but (quote cloudy) :

we don't have any handler registered for abstract base class, Packet is an abstract base class, both ARP and LLDP derives from Packet. AlivenessProtocolHandlerARP and AlivenessProtocolHandlerLLDP both derives from AbstractAlivenessProtocolHandler<P extends Packet> abstract class.

AlivenessProtocolHandlerARP and AlivenessProtocolHandlerLLDP both registers in alivenessProtocolHandlerRegistry MAP with ARP.class and LLDP.class as keys.

Nobody registers a handler with Packet.class as key.


Generated at Wed Feb 07 20:00:01 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.