[GENIUS-162] genius karaf log levels and messages should be checked Created: 04/Jun/18  Updated: 22/Jun/18  Resolved: 22/Jun/18

Status: Resolved
Project: genius
Component/s: None
Affects Version/s: None
Fix Version/s: Oxygen-SR3, Fluorine

Type: Bug Priority: Medium
Reporter: Sam Hague Assignee: nidhi adhvaryu
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: 0 minutes
Time Spent: 1 day
Original Estimate: Not Specified

Attachments: File odl1_karaf.log.tar.xz    
Issue Links:
Cloners
clones NETVIRT-1299 netvirt karaf log levels and messages... Verified
Relates
relates to NETVIRT-1299 netvirt karaf log levels and messages... Verified

 Description   

There are many logs in the karaf log that are at error and warn level that may not be needed or were added as debugging and not removed. Some logs are useful for troubleshooting and should remain. The logs should be checked to decide what can be lowered or removed.

  • can logs be moved from error and warn to info or debug?
  • can some logs be removed?

Some examples in the attached karaf log:

These logs are at WARN and ERROR, but are they really?

2018-06-06T12:35:44,760 | WARN  | Blueprint Extender: 2 | RpcServiceMetadata               | 210 - org.opendaylight.controller.blueprint - 0.9.0.SNAPSHOT | org.opendaylight.genius.alivenessmonitor-impl (packetProcessingService): interface interface org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingService has no accptable entries, assuming it is satisfied
2018-06-06T13:16:00,804 | ERROR | org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan.interfaces.ElanInterface_AsyncDataTreeChangeListenerBase-DataTreeChangeHandler-0 | InterfacemgrProvider             | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | Interface 149758239241423:br-physnet1-pa:1121 doesn't exist in config datastore

This log for br-int dpid as null, the dpid is always null initially and is later updated so is this really a warning or even info?

2018-06-06T13:00:32,489 | WARN  | opendaylight-cluster-data-notification-dispatcher-210 | OvsdbNodeListener                | 271 - org.opendaylight.genius.itm-impl - 0.5.0.SNAPSHOT | OvsdbBridgeAugmentation processBridgeUpdate: DPID for bridge br-int is NULL.
2018-06-06T13:00:32,491 | INFO  | ForkJoinPool-1-worker-3 | InterfaceTopologyStateListener   | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | DataPathId found as null for Bridge Augmentation: OvsdbBridgeAugmentation{getBridgeExternalIds=[BridgeExternalIds{getBridgeExternalIdKey=opendaylight-iid, getBridgeExternalIdValue=/network-topology:network-topology/network-topology:topology[network-topology:topology-id='ovsdb:1']/network-topology:node[network-topology:node-id='ovsdb://uuid/0cf13641-1da0-44a0-8e68-93b7d90b073c/bridge/br-int'], augmentations={}}], getBridgeName=OvsdbBridgeName{_value=br-int}, getBridgeOtherConfigs=[BridgeOtherConfigs{getBridgeOtherConfigKey=disable-in-band, getBridgeOtherConfigValue=true, augmentations={}}, BridgeOtherConfigs{getBridgeOtherConfigKey=hwaddr, getBridgeOtherConfigValue=a0:58:3e:7a:f2:9a, augmentations={}}], getBridgeUuid=Uuid{_value=98169760-e5f8-4358-905e-8c0bcdd2a621}, getControllerEntry=[ControllerEntry{getControllerUuid=Uuid{_value=493bb5a7-1e91-4857-a3d0-861e7733cdd0}, getTarget=Uri{_value=tcp:10.30.170.60:6653}, isIsConnected=false, augmentations={}}], getDatapathType=interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.DatapathTypeSystem, getFailMode=interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbFailModeSecure, getManagedBy=OvsdbNodeRef{_value=KeyedInstanceIdentifier{targetType=interface org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node, path=[org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NetworkTopology, org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.Topology[key=TopologyKey{_topologyId=Uri{_value=ovsdb:1}}], org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node[key=NodeKey{_nodeId=Uri{_value=ovsdb://uuid/0cf13641-1da0-44a0-8e68-93b7d90b073c}}]]}}, getProtocolEntry=[ProtocolEntry{getProtocol=interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbBridgeProtocolOpenflow13, augmentations={}}], isStpEnable=false}... returning...

These logs are repeating numerous times. These are just a few of the examples, but there are many more in the log. I think some were good at one point when debugging features initially, but maybe they are not needed or can be lowered to debug.

2018-06-06T13:00:32,669 | WARN  | org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.dpn.teps.info.TunnelEndPoints_AsyncDataTreeChangeListenerBase-DataTreeChangeHandler-0 | TunnelEndPointChangeListener     | 382 - org.opendaylight.netvirt.vpnmanager-impl - 0.7.0.SNAPSHOT | add: dpnId: 176300865811098: tep: 176300865811098::0: No VPN instances defined
2018-06-06T13:00:33,318 | INFO  | org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node_AsyncClusteredDataTreeChangeListenerBase-DataTreeChangeHandler-0 | NodeConnectorStatsImpl           | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | Port statistics is turned off
2018-06-06T13:00:33,325 | INFO  | ForkJoinPool-1-worker-6 | OvsInterfaceStateAddHelper       | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | Adding Interface State to Oper DS for interface: 176300865811098:br-physnet1-pa
2018-06-06T13:00:33,326 | INFO  | ForkJoinPool-1-worker-4 | OvsInterfaceStateAddHelper       | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | Adding Interface State to Oper DS for interface: 176300865811098:br-int
2018-06-06T13:00:33,333 | INFO  | ForkJoinPool-1-worker-7 | FlowBasedEgressServicesStateBindHelper | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | bindServicesOnInterfaceType Egress - WIP
2018-06-06T13:00:33,333 | INFO  | ForkJoinPool-1-worker-0 | FlowBasedEgressServicesStateBindHelper | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | bindServicesOnInterfaceType Egress - WIP
2018-06-06T13:00:33,334 | INFO  | ForkJoinPool-1-worker-5 | FlowBasedEgressServicesStateBindHelper | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | bindServicesOnInterfaceType Egress - WIP
2018-06-06T13:00:33,337 | INFO  | ForkJoinPool-1-worker-5 | FlowBasedIngressServicesStateBindHelper | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | bindServicesOnInterfaceType Ingress - WIP
2018-06-06T13:00:33,337 | INFO  | ForkJoinPool-1-worker-7 | FlowBasedIngressServicesStateBindHelper | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | bindServicesOnInterfaceType Ingress - WIP
2018-06-06T13:00:33,337 | INFO  | ForkJoinPool-1-worker-1 | FlowBasedIngressServicesStateBindHelper | 268 - org.opendaylight.genius.interfacemanager-impl - 0.5.0.SNAPSHOT | bindServicesOnInterfaceType Ingress - WIP
2018-06-06T13:03:32,992 | INFO  | ResourceBatchingManager-0 | ResourceBatchingManager          | 274 - org.opendaylight.genius.mdsalutil-api - 0.5.0.SNAPSHOT | Total taken ##time = 4ms for resourceList of size 1 for resourceType INTERFACEMGR-DEFAULT-OPERATIONAL


 Comments   
Comment by Faseela K [ 04/Jun/18 ]

Do you have any examples?

With link to one of the CSIT runs?

Remember, we had already passed one iteration of doing the same exercise, and hence would like to check what are the new ERRORs/WARNs in the list.

Comment by Faseela K [ 07/Jun/18 ]

shague : Any inputs?

Comment by Sam Hague [ 07/Jun/18 ]

updated the description with some examples. The karaf log is full of genius logging though. The logs should be checked to see if they are still needed and/or we need to reduce some to debug level.

Comment by nidhi adhvaryu [ 22/Jun/18 ]

Most of the log levels has been verified as asked in GENIUS:162

Please find it ,

Fluorine: https://git.opendaylight.org/gerrit/#/c/72869/

Oxygen: https://git.opendaylight.org/gerrit/#/c/73338/ 

Generated at Wed Feb 07 20:00:04 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.