[GENIUS-255] Log message indicating time taken for internal process should not be INFO level debug Created: 11/Dec/18 Updated: 12/Dec/18 Resolved: 12/Dec/18 |
|
| Status: | Resolved |
| Project: | genius |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Fluorine-SR2, Neon |
| Type: | Bug | Priority: | Medium |
| Reporter: | Jamo Luhrsen | Assignee: | Michael Vorburger |
| Resolution: | Done | Votes: | 0 |
| Labels: | csit, log_spam | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
there are hundreds of messages like the below in a 2.5 hour CSIT job. 81763:2018-12-10T17:18:30,595 | INFO | ResourceBatchingManager-0 | ResourceBatchingManager | 271 - org.opendaylight.genius.mdsalutil-api - 0.6.0 | Total taken ##time = 11ms for resourceList of size 1 for resourceType INTERFACEMGR-DEFAULT-CONFIG imho, these are meant for debugging internal issues and won't be helpful for any |
| Comments |
| Comment by Jamo Luhrsen [ 11/Dec/18 ] |
| Comment by Jamo Luhrsen [ 11/Dec/18 ] |
|
I'll try to take this one. |
| Comment by Michael Vorburger [ 12/Dec/18 ] |
|
> I'll try to take this one. I think this is one of those cases where just reducing INFO to DEBUG would be the right thing to do. k.faseela no objections from you guys to join the logging level of this? |
| Comment by Michael Vorburger [ 12/Dec/18 ] |
|
What we could and really should do in theory is using an infrautils.metrics.Timer for that.. but that's not this issue. |
| Comment by Jamo Luhrsen [ 12/Dec/18 ] |
|
yeah, that's all I was going to do. |